Skip to content

fix(detect): ignore Cursor Run Everything status - #2220

Open
Nagi-ovo wants to merge 2 commits into
herdrdev:masterfrom
Nagi-ovo:fix/cursor-run-everything
Open

fix(detect): ignore Cursor Run Everything status#2220
Nagi-ovo wants to merge 2 commits into
herdrdev:masterfrom
Nagi-ovo:fix/cursor-run-everything

Conversation

@Nagi-ovo

@Nagi-ovo Nagi-ovo commented Aug 3, 2026

Copy link
Copy Markdown

Fixes #1763.

Require (y) on Cursor run-approval controls so the persistent Run Everything footer is not reported as blocked. Real → Run (once) (y) prompts remain blocked, with regression coverage for wrapped footer variants.

Validation: focused Cursor regression test, manifest checks, clippy, and 3027/3028 nextest tests passed. The remaining live-handoff test fails identically on clean origin/master.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 92c875f8-06a8-48d3-bf04-d14495cfb85b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Changes

Cursor detection

Layer / File(s) Summary
Approval prompt rule updates
src/detect/manifests/cursor.toml, website/agent-detection/cursor.toml
The Cursor manifests update their version metadata and expand approval prompt matching for optional prefixes and run confirmation variants.
Cursor classification regression coverage
src/detect/manifest/tests.rs
Tests classify → Run (once) (y) as blocked with approval_prompt and fragmented “Run Everything” text as idle without a matched rule.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes prevent the persistent Run Everything footer from matching approval_prompt while preserving detection of real approval prompts described in issue #1763.
Out of Scope Changes check ✅ Passed The test and manifest updates directly support the Cursor detection fix and its regression coverage; no unrelated changes are shown.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check ✅ Passed The title clearly describes the main change: preventing Cursor's persistent Run Everything status from being detected as blocked.
Description check ✅ Passed The description directly explains the detection fix, preserved approval behavior, regression coverage, and validation results.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kangal-bot kangal-bot added the ai-review Trigger automated AI reviews for pull requests admitted by the PR gate label Aug 3, 2026
@Nagi-ovo
Nagi-ovo marked this pull request as ready for review August 3, 2026 02:28
@Nagi-ovo

Nagi-ovo commented Aug 3, 2026

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR narrows Cursor’s execution-approval detection so the persistent “Run Everything” footer remains idle while genuine → Run (once) (y) prompts remain blocked.

  • Requires Cursor run-approval lines to begin with optional followed by Run and contain (y).
  • Adds regression coverage for wrapped “Run Everything” footer variants and non-prompt status text.
  • Keeps the bundled and website-published Cursor manifests synchronized with a bumped manifest version.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/detect/manifests/cursor.toml Narrows the bundled Cursor approval rule to distinguish active Run prompts from persistent Run Everything status text.
website/agent-detection/cursor.toml Mirrors the bundled Cursor rule and metadata update in the published detection manifest.
src/detect/manifest/tests.rs Adds focused coverage confirming genuine run approval remains blocked while footer and status variants remain idle.

Reviews (2): Last reviewed commit: "fix(detect): constrain Cursor approval c..." | Re-trigger Greptile

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/detect/manifest/tests.rs (1)

303-330: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add a negative case for incidental approval text.

This test covers the real → Run (once) (y) prompt and fragmented Run Everything text. It does not cover a non-control line that satisfies the new second regex alternative. Add a case such as (y) was selected; the command will allow execution and assert Idle with no matched rule.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fd0b151b-8fb2-4bfa-b02b-0645a92d5eec

📥 Commits

Reviewing files that changed from the base of the PR and between eacea2d and eb19575.

📒 Files selected for processing (3)
  • src/detect/manifest/tests.rs
  • src/detect/manifests/cursor.toml
  • website/agent-detection/cursor.toml

Comment thread src/detect/manifests/cursor.toml Outdated
@Nagi-ovo

Nagi-ovo commented Aug 3, 2026

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Trigger automated AI reviews for pull requests admitted by the PR gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cursor Agent CLI falsely reports blocked when footer shows Run Everything

2 participants