chore(olcrtc): update pinned runtime - #155
Conversation
📝 WalkthroughWalkthroughThe pull request updates the pinned olcRTC commit across CI, preview, APK, and release workflows, and the offline build script. It also revises comments describing the upstream changes included in the pin. ChangesolcRTC pin update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
| NAIVE_VERSION: v149.0.7827.114-1 | ||
| OLCRTC_REPO: https://github.com/openlibrecommunity/olcrtc.git | ||
| OLCRTC_COMMIT: 1255cf8248ee4a52cb355ceb8cf72281a5f1affd | ||
| OLCRTC_COMMIT: 42ae4e0c6a1af3e01c52cf0149502cc13c326a3f |
There was a problem hiding this comment.
This changes the CI pin to 42ae4e0c6a1af3e01c52cf0149502cc13c326a3f, but other APK-producing workflows still set their own OLCRTC_COMMIT values. Those environment values override the new olcrtc.sh default, so release, preview, build, or Depot artifacts can compile a different sidecar than the one CI validates and miss the VP8 peer-restart fix.
There was a problem hiding this comment.
Fixed in 3221c17c. The active build, preview, release, and CI workflows now use the same exact full commit as the build script. The inert Depot definition was synchronized as well, without enabling it. Each sidecar cache key already includes OLCRTC_COMMIT.
|
Superseded by #157. The combined PR replaces this pin with the runtime used by the validated client and server pair. |
Summary
Validation
29280269233: passedRollout
This is a staged candidate. Merge requires Android end-to-end verification with the matching server build.
Greptile Summary
This PR updates the pinned olcRTC sidecar runtime. The main changes are:
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "ci(olcrtc): synchronize workflow pins" | Re-trigger Greptile