Skip to content

chore(olcrtc): update pinned runtime - #155

Closed
hawkff wants to merge 2 commits into
mainfrom
chore/olcrtc-pin-42ae4e0
Closed

chore(olcrtc): update pinned runtime#155
hawkff wants to merge 2 commits into
mainfrom
chore/olcrtc-pin-42ae4e0

Conversation

@hawkff

@hawkff hawkff commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • pin the olcRTC client sidecar to an immutable upstream commit
  • update the Namespace sidecar cache key to match
  • include the upstream VP8 peer-restart corroboration fix

Validation

  • CodeRabbit CLI: no findings
  • pin consistency review: no blockers
  • Namespace CI run 29280269233: passed

Rollout

This is a staged candidate. Merge requires Android end-to-end verification with the matching server build.

Greptile Summary

This PR updates the pinned olcRTC sidecar runtime. The main changes are:

  • The olcRTC commit is aligned across APK-producing workflows.
  • The build script default uses the same immutable upstream commit.
  • The script comments now include the VP8 peer-restart fix in the pinned-runtime rationale.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
.depot/workflows/build-apk.yml Updates the Depot APK workflow to use the shared olcRTC commit.
.github/workflows/build.yml Updates the build workflow to use the shared olcRTC commit.
.github/workflows/ci.yml Keeps CI on the same olcRTC commit as the APK workflows.
.github/workflows/preview.yml Updates the preview workflow to use the shared olcRTC commit.
.github/workflows/release.yml Updates the release workflow to use the shared olcRTC commit.
buildScript/lib/olcrtc.sh Pins the default olcRTC commit and documents the fixes included in that runtime.

Reviews (2): Last reviewed commit: "ci(olcrtc): synchronize workflow pins" | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request updates the pinned olcRTC commit across CI, preview, APK, and release workflows, and the offline build script. It also revises comments describing the upstream changes included in the pin.

Changes

olcRTC pin update

Layer / File(s) Summary
Update olcRTC revision pin
.github/workflows/*.yml, .depot/workflows/build-apk.yml, buildScript/lib/olcrtc.sh
Build workflows and the build script now use commit 42ae4e0c6a1af3e01c52cf0149502cc13c326a3f; accompanying build-script feature notes are updated.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: starifly, arm64v8a

Poem

A rabbit hops through pins so neat,
New olcRTC makes builds complete.
CI follows the commit trail,
While notes explain the updated tale.
Thump-thump—reproducibility wins!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: updating the pinned olcrtc runtime commit.
Description check ✅ Passed The description is clearly related to the commit pin update, workflow cache alignment, and included fix.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

Comment thread .github/workflows/ci.yml
NAIVE_VERSION: v149.0.7827.114-1
OLCRTC_REPO: https://github.com/openlibrecommunity/olcrtc.git
OLCRTC_COMMIT: 1255cf8248ee4a52cb355ceb8cf72281a5f1affd
OLCRTC_COMMIT: 42ae4e0c6a1af3e01c52cf0149502cc13c326a3f

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Sidecar Pins Diverge

This changes the CI pin to 42ae4e0c6a1af3e01c52cf0149502cc13c326a3f, but other APK-producing workflows still set their own OLCRTC_COMMIT values. Those environment values override the new olcrtc.sh default, so release, preview, build, or Depot artifacts can compile a different sidecar than the one CI validates and miss the VP8 peer-restart fix.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3221c17c. The active build, preview, release, and CI workflows now use the same exact full commit as the build script. The inert Depot definition was synchronized as well, without enabling it. Each sidecar cache key already includes OLCRTC_COMMIT.

@hawkff

hawkff commented Jul 14, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #157. The combined PR replaces this pin with the runtime used by the validated client and server pair.

@hawkff hawkff closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant