Draft
Conversation
We have a really great hashing algorithm in the Hiero Consensus Node in the NonCryptographicHashing file. This PR brings it over here, but leaves it package private. A separate PR should make it public and possibly move it somewhere else. And a future PR should fix all other hashCode() implementations, including for generated PBJ objects. Signed-off-by: Richard Bair <[email protected]>
Signed-off-by: Richard Bair <[email protected]>
Signed-off-by: Richard Bair <[email protected]>
…ated code and cleanup unneeded methods Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Richard Bair <[email protected]>
…e algorithms for testing Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Richard Bair <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Richard Bair <[email protected]>
…other tests Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
Signed-off-by: Jasper Potts <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a really great hashing algorithm in the Hiero Consensus Node in the NonCryptographicHashing file. This PR brings it over here, but leaves it package private. A separate PR should make it public and possibly move it somewhere else. And a future PR should fix all other hashCode() implementations, including for generated PBJ objects.
We should bring over the unit tests too.
In addition, Leemon has an improvement to the bytes-to-long method. We shouldn't check this in until we have that change applied. For that reason, this PR is still a draft.