feat: Provide a mechanism for server streaming applications to register a callback#320
Open
mattp-swirldslabs wants to merge 11 commits intomainfrom
Open
feat: Provide a mechanism for server streaming applications to register a callback#320mattp-swirldslabs wants to merge 11 commits intomainfrom
mattp-swirldslabs wants to merge 11 commits intomainfrom
Conversation
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
JUnit Test Report 67 files +1 67 suites +1 3m 2s ⏱️ +34s Results for commit ea87a87. ± Comparison against base commit 44991ec. This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Matt Peterson <[email protected]>
Integration Test Report 297 files +1 297 suites +1 8m 50s ⏱️ + 1m 39s Results for commit ea87a87. ± Comparison against base commit 44991ec. This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
andrewb1269
approved these changes
Nov 19, 2024
Contributor
andrewb1269
left a comment
There was a problem hiding this comment.
Reviewed pbj-core/pbj-grpc-helidon/build.gradle.kts and looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
registerOnErrorHandlerto thePipelineinterfaceonError()method which fixes Helidon exceptions are not propagated up through PbjProtocolHandler to the application viaonError#304Related issue(s):
Fixes #303, #304
Notes for reviewer:
Checklist