🎨 Palette: Fix keyboard trap on TUI selector#154
Conversation
Added explicit handling for the `\x03` (Ctrl-C) byte during raw keyboard input reading within `libs/terminal_ui.py`. In raw mode, `Ctrl-C` does not naturally raise a `KeyboardInterrupt`. Without checking for it explicitly, users become trapped in the TUI selector with no standard escape route, breaking their mental model of terminal abort functionality. Before, pressing Ctrl-C in the TUI selection would do nothing or return `\x03` as an unhandled byte, ignoring the interrupt. After, pressing Ctrl-C properly aborts the selection loop by explicitly raising a `KeyboardInterrupt` and allowing standard app flow to safely exit. Ensures that keyboard shortcuts crucial for navigation and state escape are universally supported across the terminal, avoiding keyboard traps which severely degrade user experience for those relying on standard interrupts to back out.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 13 minutes and 54 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
1 participant
💡 What: Added explicit handling for the
\x03(Ctrl-C) byte during raw keyboard input reading withinlibs/terminal_ui.py.🎯 Why: In raw mode,
Ctrl-Cdoes not naturally raise aKeyboardInterrupt. Without checking for it explicitly, users become trapped in the TUI selector with no standard escape route, breaking their mental model of terminal abort functionality.📸 Before/After: Before, pressing Ctrl-C in the TUI selection would do nothing or return
\x03as an unhandled byte, ignoring the interrupt. After, pressing Ctrl-C properly aborts the selection loop by explicitly raising aKeyboardInterruptand allowing standard app flow to safely exit.♿ Accessibility: Ensures that keyboard shortcuts crucial for navigation and state escape are universally supported across the terminal, avoiding keyboard traps which severely degrade user experience for those relying on standard interrupts to back out.
PR created automatically by Jules for task 3388155600786924922 started by @haseeb-heaven