Skip to content

🎨 Palette: [UX improvement] Fix terminal TUI keyboard trap and provide clear exit hints#151

Open
haseeb-heaven wants to merge 1 commit into
mainfrom
palette-fix-tui-trap-14208961604337589538
Open

🎨 Palette: [UX improvement] Fix terminal TUI keyboard trap and provide clear exit hints#151
haseeb-heaven wants to merge 1 commit into
mainfrom
palette-fix-tui-trap-14208961604337589538

Conversation

@haseeb-heaven

Copy link
Copy Markdown
Owner
  • 💡 What: We added explicit handling for the \x03 (Ctrl-C) byte in the terminal raw input loop (_read_key) for both Unix and Windows. We also added an explicit hint to the footer (Esc/Ctrl-C to cancel.) and updated the prompt fallback to format choices directly into the text (so rich Prompt fallback does not fail invisibly).
  • 🎯 Why: When terminal raw mode is enabled, it prevents standard OS-level SIGINT signals from firing. If an explicit trap isn't implemented for \x03, the user encounters a keyboard trap and cannot easily exit the application gracefully. Fallbacks also need to clearly state what inputs are accepted without triggering syntax errors due to rich markup.
  • 📸 Before/After:
    • Before: Users pressing Ctrl-C in terminal selector menus did nothing. Fallbacks lacked formatted hints for default options.
    • After: Users pressing Ctrl-C correctly triggers a KeyboardInterrupt to exit or cancel gracefully. Fallback prompts explicitly read [code|chat|...] correctly escaped. The UI correctly renders Use Up/Down arrows and Enter to select. Esc/Ctrl-C to cancel. in the footer.
  • ♿ Accessibility: Fixing a keyboard trap is a critical accessibility requirement (WCAG 2.1.2 No Keyboard Trap), ensuring users are never "stuck" within an interactive loop that they cannot escape via standard key bindings. Providing explicit UI guidance lowers cognitive load.

PR created automatically by Jules for task 14208961604337589538 started by @haseeb-heaven

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@haseeb-heaven, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 3 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7bd2c6a9-50e2-44f1-8413-9edf6c274c4e

📥 Commits

Reviewing files that changed from the base of the PR and between 2a47494 and 67ff380.

📒 Files selected for processing (2)
  • .jules/palette.md
  • libs/terminal_ui.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-fix-tui-trap-14208961604337589538

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant