Add fetch scaffold subdirs, test coverage, and CI workflow - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
--scaffold-subdirsoption to themafutils fetchcommand, allowing output files to be grouped into subdirectories named by reference scaffold instead of a flat output directory. The implementation ensures robust directory creation, error handling, and integration with both block and scaffold fetch modes. Documentation is updated to reflect the new option and recent test coverage improvements.New Feature: Scaffold Subdirectory Output
--scaffold-subdirsoption tomafutils fetch, grouping output files into<output>/<scaffold>/<basename>directories for improved organization. This is supported in both block and scaffold modes, with safeguards to avoid use with--single-output. [1] [2] [3]Implementation Details
buildOutputPathhelper to generate output paths based on thescaffold_subdirsflag, and updated all relevant code paths to use it. [1] [2] [3] [4]Command-line and API Integration
scaffold_subdirsoption. [1] [2] [3] [4] [5] [6] [7]Documentation Updates
README.mdto document the new--scaffold-subdirsoption.DEVELOPMENT.mdwith details on new and existing test coverage, including tests for real-world MAF data and regression checks.Continuous Integration
.github/workflows/tests.yml) to automatically run the test suite on pushes and pull requests tomain.… test workflow