Repository navigation
fix: make referral and milestone payouts atomic - #155
Open
0xQuerencia wants to merge 1 commit into
Open
0xQuerencia wants to merge 1 commit into
0xQuerencia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified data-integrity defect
Referral fulfillment currently marks a referral
rewarded_atbefore separately invokingadjust_user_pixels. If the wallet transaction fails, the referral remains claimed and can never earn the promised pixels on retry. Similarly, separate milestone count and credit operations can race when several referred projects are approved concurrently.Fix
settle_referral_reward_atomic: validates the reward, serializes per-referrer payout/milestones with a user-row lock, marks the individual referral and credits the wallet and any applicable milestone in one PostgreSQL transaction.Do not deploy without migration 0236. Keep open until CI, code review, and database checks are green. Production was not modified by creating this PR.