Repository navigation
fix: preserve banked Restoration Energy during update reviews - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified behavior vs intended economy
Pixl's payout code documents earned Restoration Energy as banked forever, but both the server and reviewer dashboard only counted rows with current status
approved. Re-shipping an approved project temporarily sets its status toshipped, withprior_approved_hourscaptured specifically to preserve the last approved baseline. Previously earned RE could disappear until the update was reapproved.Changes
lifetimeRe(used by reviewer payout calculations) with the same banked-hours baseline.shipped,fraud_review,second_reviewandneeds_changes, while excluding first-time unapproved submissions.Policy intent and safeguards
No credit for new work until approval. Banned projects remain excluded. No database migration, no direct production changes. This PR requires CI and financial review before merge.
Remaining work
Hardware funding order deduplication and Trial item update payouts need database-backed settlement/idempotency guarantees and are not silently changed here.