Mv3 quick#230
Draft
rudolphos wants to merge 6 commits into
Draft
Conversation
rudolphos
force-pushed
the
mv3-quick
branch
4 times, most recently
from
4d856be to
2f049a0
Compare
Owner
|
Hello, thanks for the draft PR. The Chrome MV3 deadline is approaching so I figured I'd take a look at this before then. Are you planning on adding any more commits? |
3.7.7 - Sends wake message only on key press (default alt+click) - Removed persistent SW keepalive (chrome.alarms) every 20 sec
Refactor keydown event listener to include combo check before sending message.
Author
|
@gyng Nope. I just migrated it solely for Chromium usage though and had to strip some of the Firefox-only features and boilerplate code to make it simpler to maintain. No further commits for now as it's working for me like it did on MV2 - tested custom patterns, they all worked as before, and fixed an issue where service worker went to sleep persistently and thus making it impossible to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.