Merged
Conversation
make sure tests in test_003mfpackages.py are not ignored Run tests in a model directory set by a fixture
Replace tmpdir by the newer tmp_path
keep use of tempfile in caching and encoding
dbrakenhoff
approved these changes
Mar 18, 2026
Collaborator
dbrakenhoff
left a comment
There was a problem hiding this comment.
Looks good. Didn´t check it all super carefully, and the new monkeypatch tests are a bit hard to follow but I'm sure if the tests pass and run quickly this is is a big improvement.
Collaborator
Author
|
Yes, the monkeypatch-stuff is what copilot came up with when I asked to increase the coverage. They are all in the last two test-files, so easy to remove again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure notebooks and tests produce output in folder that are not committed to Git:
Also this PR improves some tests:
tmp_pathinstead oftmpdirnlmod.read.administrative.download_kadaster_percelendownload_instead ofget_)Some other changes:
download_percelen_gdf