CI Fix: separating docs dependencies from requirements.txt - #5403
Open
GarethCabournDavies wants to merge 2 commits into
Open
CI Fix: separating docs dependencies from requirements.txt#5403GarethCabournDavies wants to merge 2 commits into
GarethCabournDavies wants to merge 2 commits into
Conversation
Contributor
|
@GarethCabournDavies Look over #5391 ... It looks like pypi has made another release, and the underlying issue has still not been fixed. As this could still raise issues in other places we should continue with the strategy in 5391 of either avoiding pypi releases with this issue or going with the other fix there (see commit history) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent CI jobs have been failing the docker build because it looks like the docs dependencies are clashing with the prerequisites needed by the docker build.
Instead of manually uninstalling them, which does work, I've had a look at separating the docs dependencies so that they aren't used when building the docker image.
We can run
pip install ".[docs]"- same way as we do with[test]or[igwn], and get the docs stuff in.Standard information about the request
This is a: bug fix / prerequisites separation
This change fixes: the CI, and docker build
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Motivation
Fix the CI, make things a bit more robust
Contents
Testing performed
If the CI passes for this PR, then we are good. It has passed on my fork, so should pass here as well