Repository navigation
Re-flatten grid items in StandardLayoutArticleGrid DOM - #17183
Open
frederickobrien wants to merge 6 commits into
Open
frederickobrien wants to merge 6 commits into
frederickobrien wants to merge 6 commits into
Conversation
🚀 Image for dotcom-rendering pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:376b054fadc9838cf6a8b6917c7d64ae51c1a809294c99b98a79306b0aede621"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-flatten-grid-items"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-34083"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
frederickobrien
force-pushed
the
flatten-grid-items
branch
from
November 6, 2026 13:14
ab18224 to
fec6d16
Compare
frederickobrien
force-pushed
the
flatten-grid-items
branch
from
November 6, 2026 13:50
d3dcbfa to
a8555e5
Compare
frederickobrien
marked this pull request as ready for review
November 6, 2026 13:50
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
frederickobrien
force-pushed
the
flatten-grid-items
branch
from
November 6, 2026 16:17
a8555e5 to
42f3891
Compare
| format.design !== ArticleDesign.Recipe && | ||
| format.design !== ArticleDesign.Gallery; | ||
|
|
||
| const isImmersiveNonNews = (format: ArticleFormat) => |
Contributor
There was a problem hiding this comment.
it might be good to put these utils into a file that we can then test, otherwise we've only got them covered by storybook tests?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts StandardLayoutArticleGrid to ensure all grid items are at the same level in the DOM. The spark for this was fixing an issue with the centre rule (pictured below) but on reflection a flat DOM structure feels like a cleaner, more flexible approach and one I think we ought to preserve. Browser support of
display: contents;isn't great and in principle I think the less nesting the better.I've refactored other parts of the code to (hopefully) ensure the portrait layout looks as it did with the previous configuration. I've also included in some right padding for meta elements in the portrait layout from leftCol up to ensure we don't ever have them squashed right up against the border.
Also chucked in: an immersive headline boldness fix.