Repository navigation
Fix the series tag and border issue - #17154
Closed
joshuaguardian wants to merge 13 commits into
Closed
joshuaguardian wants to merge 13 commits into
joshuaguardian wants to merge 13 commits into
Conversation
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:beee3fed1ffd58762e2a657dd720238d87cca02562d615fb2ac6dfdd1bec6da5"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-fix-design-feedback"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-33961"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
joshuaguardian
force-pushed
the
fix/design-feedback
branch
from
November 5, 2026 09:45
dc94429 to
abf0af3
Compare
joshuaguardian
force-pushed
the
fix/design-feedback
branch
from
November 5, 2026 12:19
caff4b2 to
2792d7e
Compare
joshuaguardian
force-pushed
the
fix/design-feedback
branch
from
November 5, 2026 14:17
4f71df6 to
3ce5803
Compare
joshuaguardian
force-pushed
the
fix/design-feedback
branch
from
November 5, 2026 14:53
84f2112 to
e5aca45
Compare
joshuaguardian
force-pushed
the
fix/design-feedback
branch
from
November 5, 2026 17:02
3fc36cd to
7f667b6
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Legacy immersive articles omit layoutType, causing wrapped series tags to lose their 28px line height and crowd the padded backgrounds.
1 open issue
What changed in this PR
This PR adjusts series-tag styling and article-grid borders to better match the designs, focusing on immersive portrait and landscape layouts.
Changes:
- Refines series-tag spacing, padding, positioning, and responsive line heights.
- Adjusts immersive grid borders and portrait title-rule alignment.
- Adds Storybook examples for standard, gallery, and immersive tags, including wrapped titles.
| File | Description |
|---|---|
dotcom-rendering/src/layouts/StandardLayoutArticleGrid.tsx |
Adjusts immersive centre rules and removes the portrait negative margin. |
dotcom-rendering/src/components/SeriesSectionLink.tsx |
Updates responsive series-tag styling and layout-specific spacing. |
dotcom-rendering/src/components/SeriesSectionLink.stories.tsx |
Adds visual examples across layouts and viewport sizes. |
dotcom-rendering/src/components/ArticleTitle.tsx |
Refines immersive title margins and portrait rule alignment. |
Review effort: Balanced
joshuaguardian
force-pushed
the
fix/design-feedback
branch
from
November 6, 2026 14:42
edab99a to
4512ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this change?
Fix the series tag and border issue
Why?
Didnt match designs
How has this change been tested?
Tested locally manually and in chromatic
Screenshots