Bugfix WebRTCBin.createOffer/createAnswer; Support for WebRTC DataChannel (string/data)#271
Open
jw-tecuri wants to merge 4 commits intogstreamer-java:masterfrom
Open
Bugfix WebRTCBin.createOffer/createAnswer; Support for WebRTC DataChannel (string/data)#271jw-tecuri wants to merge 4 commits intogstreamer-java:masterfrom
jw-tecuri wants to merge 4 commits intogstreamer-java:masterfrom
Conversation
|
Quite useful changes! - especially the garbage collection of promises are really important. Maybe other parts of the codebase actually has the same/similar issue? Suggestion: Add offset+length versions of the GBytes and datachannel data methods for effeciency reasons, to avoid having to copy over byte arrays in situations where only a portion needs to be used (very common). Maybe something along the lines of: WebRTCDataChannel: GBytes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270