Repository navigation
xds-client: add LRS message types, LrsCodec and its prost implementation - #3012
Merged
Merged
Conversation
Adds the lrs module, with the crate-owned LoadStatsRequest and LoadStatsResponse types, and the LrsCodec trait converting them to and from the wire format. Locality now derives PartialEq, Eq and Hash, to be used in the load stats, and as a map key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #2764
This is a part of an LRS (Load Reporting Service) client for
xds-client. gRPC uses LRS to report per-cluster and per-locality load (call counts, drops, backend metrics) to the control plane. The LRS client needs crate-owned message types and a codec layer, like ADS has withDiscoveryRequest/DiscoveryResponseandXdsCodec. That keeps the client logic independent of the protobuf implementation.Follow-up PRs add the load store that records loads, and the worker that reports them over a
StreamLoadStatsstream.Changes
xds_client::lrsmodule to keep LRS code separate from the existing ADS implementation.xds_client::lrsmodule.xds_client::lrs::messages.ProstCodecalso implements theLrsCodectrait. This will be used for testing the upcoming lrs worker implementation.