Repository navigation
grpc-xds: Use protobuf-generated modules - #2958
Merged
Merged
Conversation
In 0858621 we had to invoke protoc separately for each .proto and construct our own mod structure, because protoc failed to generate code if two messages had the same name, even if those messages were in different packages. Now that 0ecf925 upgraded to Protobuf 36.2, we no longer need to make our own structure, and can simplify the build.rs (even if the resulting mods aren't as obvious as what we had developed ourselves).
Member
Author
|
@dfawley, you may want to take a glance to see the module naming scheme protobuf is using. |
Member
Author
|
|
Member
Author
|
@gu0keno0, do you want to take a look? |
gu0keno0
approved these changes
Nov 10, 2026
gu0keno0
left a comment
gu0keno0
left a comment
Contributor
There was a problem hiding this comment.
Thanks. With the use statements, hopefully we don't need to worry about these paths that much.
Contributor
Member
Author
|
I've sent out #3021 to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0858621 we had to invoke protoc separately for each .proto and construct our own mod structure, because protoc failed to generate code if two messages had the same name, even if those messages were in different packages. Now that 0ecf925 upgraded to Protobuf 36.2, we no longer need to make our own structure, and can simplify the build.rs (even if the resulting mods aren't as obvious as what we had developed ourselves).