Repository navigation
grpc-js: Preserve HTTP/2 reset codes on write errors - #3111
Merged
murgatroid99 merged 1 commit intoOct 28, 2026
Merged
Conversation
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
murgatroid99
approved these changes
Oct 28, 2026
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GOAWAY refuses a queued HTTP/2 stream, its write-error callback can run before the close handler. That path drops
rstCode, soREFUSED_STREAMis surfaced asUNAVAILABLEinstead of being transparently retried.Preserve the reset code on write errors so the existing retry logic can recognize refused streams. Add regression tests covering retry without duplicate processing, disabled retries, and connection drops after processing.