Repository navigation
server-verifier: use the request's output_type as is - #98
Merged
Merged
Conversation
Even specifying `output_type=arrow` was overridden by `json`, so just use it as is. As a result, when `output_type=arrow`, regression tests may now show differences in the Apache Arrow column type depending on the version of Groonga being used. So, the type is normalized.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
This pull request preserves requested output formats and normalizes Apache Arrow dictionary types across Groonga versions.
Changes:
- Stops forcing requests to JSON.
- Normalizes dictionary-encoded Arrow types.
- Adds regression tests for string and list dictionary types.
| File | Description |
|---|---|
test/test-response-comparer.rb |
Tests dictionary type normalization. |
lib/groonga-query-log/server-verifier.rb |
Preserves the request’s output type. |
lib/groonga-query-log/response-comparer.rb |
Normalizes dictionary-encoded column types. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
komainu8
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even specifying
output_type=arrowwas overridden byjson, so just use it as is.As a result, when
output_type=arrow, regression tests may now show differences in the Apache Arrow column type depending on the version of Groonga being used.So, the type is normalized.