Added support for no-padded day of month (%-d)#11
Open
piotrekbator wants to merge 2 commits intogrk:masterfrom
Open
Added support for no-padded day of month (%-d)#11piotrekbator wants to merge 2 commits intogrk:masterfrom
piotrekbator wants to merge 2 commits intogrk:masterfrom
Conversation
Owner
|
Is this gem necessary anymore? I think rails-i18n should cover this. |
Author
|
Rails-i18n doesn't inflect month names - at least I'm unable to find any trace of it being able to do it. Am I wrong? Besides, your gem works perfectly well, I've used it for years, so why bother looking for alternatives :) |
Owner
|
@piotrekbator could you check out the modernize branch? It should have tests passing on a modern ruby version, and hopefully work OK in a Rails app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to now month names were inflected only when used after %d (0-padded) or %e (blank-padded). This adds no-padded version - %-d to the list.