fix(auth): add gmail.settings.basic scope to auth login picker#832
fix(auth): add gmail.settings.basic scope to auth login picker#832nuthalapativarun wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 86dc1d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the authentication scope configuration to include 'gmail.settings.basic', ensuring that users have the necessary permissions for Gmail filter-related operations. It also includes safety checks to prevent redundant scope requests when full Gmail access is already granted, along with associated test coverage to maintain system reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the gmail.settings.basic OAuth scope to the Google Workspace CLI, allowing users to select it during authentication. It also configures the scope to be filtered out as redundant if the broader mail.google.com scope is already present, and includes corresponding unit tests to verify this behavior. There are no review comments, so I have no feedback to provide.
Description
Adds
gmail.settings.basicscope to theauth loginscope picker. This scope is required forusers.settings.filters.*commands but was previously missing, causing 403insufficientPermissionserrors for users who authenticated without it.The scope is suppressed when the full Gmail scope (
mail.google.com) is already selected, as it is a strict subset.Closes #668
Checklist:
google-*crates).cargo fmt --allto format the code perfectly.cargo clippy -- -D warningsand resolved all warnings.pnpx changeset) to document my changes.