Repository navigation
feat: default 3D map UI controls to off outside UiControlsActivity and update 16.0.1 docs/catalogs - #89
Conversation
809691c to
c17d393
Compare
| val compass: Boolean = true, | ||
| val panVertical: Boolean = true, | ||
| val panHorizontal: Boolean = true, | ||
| val zoom: Boolean = false, |
There was a problem hiding this comment.
Quick question: is turning all the UI controls off by default meant for every sample, or mainly to get clean screenshots for the catalog? If it is intended, could we mention it in the PR description? With the docs: prefix it will not show up in the changelog, and people will see different behaviour in every sample.
There was a problem hiding this comment.
Yes, turning the UI controls off by default is intentional across the general samples to keep the 3D map viewport uncluttered (while keeping all 6 controls enabled by default in the dedicated UI Controls sample: UiControlsActivity in ComposeDemos, kotlin-app, and java-app, and still toggleable anytime via Quick Settings).
Good catch on the changelog — I've updated the PR title prefix from docs: to feat: so it is included in the changelog, and documented the behavior change in the PR description.
| } | ||
| } | ||
|
|
||
| private fun enableImmersiveMode() { |
There was a problem hiding this comment.
Just a random idea: we already have the same immersive mode setup in CameraControlsActivity and SampleBaseActivity, and this activity already depends on com.example.maps3d.common. Would it make sense to move it to a small extension there (e.g. Activity.enableImmersiveMode()) so the samples share one copy?
There was a problem hiding this comment.
Great suggestion! Extracted Activity.enableImmersiveMode() into Utilities.kt in com.example.maps3d.common and updated MapsLocalizationActivity, CameraControlsActivity, UiControlsActivity, and SampleBaseActivity (Kotlin & Java) to share it in fbc0306.
| if not success: | ||
| print("Failed to scale image.") | ||
| sys.exit(1) | ||
| # 3. Scale Image by 50% (cross-platform: ffmpeg / convert / sips) |
There was a problem hiding this comment.
nit: the comment mentions convert, but we only try ffmpeg and then sips. Same in ComposeDemos/automation_script.py.
| # 3. Scale Image by 50% (cross-platform: ffmpeg / convert / sips) | |
| # 3. Scale Image by 50% (cross-platform: ffmpeg, falling back to sips on macOS) |
There was a problem hiding this comment.
Fixed in both Maps3DSamples/ApiDemos/catalog_automation.py and Maps3DSamples/ComposeDemos/automation_script.py in fbc0306.
…ts CATALOG.md for 16.0.1 # Conflicts: # Maps3DSamples/advanced/gradle/libs.versions.toml
…d default UI controls to off
757dcd5 to
fce35e7
Compare
dkhawk
changed the title
…larify scaling comments
Summary
Follow-up documentation, sample catalog, and UI control default updates for
play-services-maps3d:16.0.1after mergingPR #78,PR #84, andPR #87:Map3DSettings.kt&UiControlsActivity):Map3DUiControls(zoom,tilt,rotate,compass,panVertical,panHorizontal) tofalseacross general sample activities so samples and catalog screenshots keep an uncluttered 3D viewport (users can still toggle any UI control on at runtime via the Quick Settings dialog).UiControlsActivityinComposeDemos,kotlin-app, andjava-app).Utilities.kt):Activity.enableImmersiveMode()into:Maps3DSamples:ApiDemos:common(com.example.maps3d.common) soSampleBaseActivity(Kotlin & Java),MapsLocalizationActivity,CameraControlsActivity, andUiControlsActivityshare a single implementation.SAMPLE_CATALOG.md& ModuleREADME.mds):SAMPLE_CATALOG.md,Maps3DSamples/ComposeDemos/app/README.md,Maps3DSamples/ApiDemos/kotlin-app/README.md, andMaps3DSamples/ApiDemos/java-app/README.md.PlacesUIKit3D/README.mddocumenting the architecture, features, setup, and test suite of the standalonePlacesUIKit3Dshowcase module, and links all catalog references to it.MIGRATION_GUIDE.md&Maps3DSamples/ApiDemos/migration_guide.md:0.2.2 -> 16.0.1migration guide to cover both16.0.1fixes (JDK 21+javacparameter annotation fix onMap3DControland restored Jetpack Compose$stablefields),OnMap3DClickListener(event.location&event.placeId), themaps3dLoadingTintColor->maps3dTintColortheme attribute rename, requiredmapModeinMap3DInitConfig.create(...), and zero-argOnMarkerClickListenerlambdas.snippets/CATALOG.md&snippets/scripts/catalog_api.py:snippets/CATALOG.mdto index Map Localization (MapLocalizationSnippets.kt/MapLocalizationSnippets.java) and UI Controls (UiControlSnippets.kt/UiControlSnippets.java) with exact line ranges and region tags (maps_android_3d_localization_*,maps_android_3d_ui_controls_*).catalog_api.pyso parenthesized text in@SnippetGroup/@SnippetItemfields and multi-line string concatenations (" + ") are parsed without truncation.