Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

Some samples currently use datetime.datetime.utcnow(), which raises a deprecation warning. Update samples to use datetime.datetime.now instead

Fixes b/457135528

@daniel-sanche daniel-sanche requested review from a team as code owners January 30, 2026 22:07
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 30, 2026
@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Jan 30, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the codebase to use datetime.datetime.now(datetime.UTC) instead of the deprecated datetime.datetime.utcnow(). This change ensures that all timestamp generation is timezone-aware and aligns with modern Python best practices, preventing future deprecation warnings and potential issues with timezone handling.

Highlights

  • Deprecation Warning Resolution: Updated all instances of datetime.datetime.utcnow() to datetime.datetime.now(datetime.UTC) to address deprecation warnings in Python.
  • Timezone-Aware Timestamps: Ensured consistent and timezone-aware handling of UTC timestamps across samples, tests, and utility functions, aligning with modern Python best practices.
  • Codebase Modernization: Modernized timestamp generation methods throughout the codebase to improve maintainability and prevent future compatibility issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the deprecation of datetime.datetime.utcnow() by replacing it with the timezone-aware datetime.datetime.now(datetime.UTC). The changes are applied consistently across various sample and test files. I've suggested a minor simplification in a few places where a redundant timezone was being set. Overall, this is a good and necessary update.

Comment on lines 60 to 61
datetime.datetime.now(datetime.UTC)
.replace(microsecond=0, tzinfo=UTC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The tzinfo=UTC in the replace() call is redundant because datetime.datetime.now(datetime.UTC) already returns a timezone-aware datetime object. You can simplify this.

Suggested change
datetime.datetime.now(datetime.UTC)
.replace(microsecond=0, tzinfo=UTC)
datetime.datetime.now(datetime.UTC).replace(microsecond=0)

Comment on lines 57 to 58
datetime.datetime.now(datetime.UTC)
.replace(microsecond=0, tzinfo=UTC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The tzinfo=UTC in the replace() call is redundant because datetime.datetime.now(datetime.UTC) already returns a timezone-aware datetime object. You can simplify this.

Suggested change
datetime.datetime.now(datetime.UTC)
.replace(microsecond=0, tzinfo=UTC)
datetime.datetime.now(datetime.UTC).replace(microsecond=0)

Comment on lines 44 to 45
datetime.datetime.now(datetime.UTC)
.replace(microsecond=0, tzinfo=UTC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The tzinfo=UTC in the replace() call is redundant because datetime.datetime.now(datetime.UTC) already returns a timezone-aware datetime object. You can simplify this.

Suggested change
datetime.datetime.now(datetime.UTC)
.replace(microsecond=0, tzinfo=UTC)
datetime.datetime.now(datetime.UTC).replace(microsecond=0)

@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants