chore: librarian onboard pull request: 20260204T073039Z (google-cloud-apiregistry) #15522
+15,669
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @chalmerlowe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the onboarding of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request onboards the new google-cloud-apiregistry client library. The changes are mostly boilerplate generated by the Librarian CLI. I've found a few areas for improvement: the API description in .repo-metadata.json is empty, and the logging examples in the README files use placeholders. I've provided suggestions to address these points.
|
|
||
| .. code-block:: console | ||
|
|
||
| export GOOGLE_SDK_PYTHON_LOGGING_SCOPE=google.cloud.library_v1 |
Contributor
There was a problem hiding this comment.
The logging example uses a placeholder library_v1. This should be updated to apiregistry_v1beta to be specific to this library.
Suggested change
| export GOOGLE_SDK_PYTHON_LOGGING_SCOPE=google.cloud.library_v1 | |
| export GOOGLE_SDK_PYTHON_LOGGING_SCOPE=google.cloud.apiregistry_v1beta |
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging the potentially missed library name replacement.
Having said that, the current text is as it should be. Because this is generic text used for several hundred libraries, the template uses the term library_v1 to avoid the additional complexity of updating all the names for each module.
Please remember this.
I am resolving all comments in this PR related to library_v1.
Contributor
There was a problem hiding this comment.
Thank you for clarifying that the use of library_v1 is intentional due to the generic nature of the template across multiple libraries. I understand the design choice and will take this into account for future reviews.
chalmerlowe
commented
Feb 4, 2026
Updates api_description
Contributor
Author
|
The |
chalmerlowe
changed the title
gkevinzheng
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to onboard a new Cloud Client Library.
BEGIN_COMMIT
feat: onboard a new library
PiperOrigin-RevId: 848064295
Library-IDs: google-cloud-apiregistry
END_COMMIT
Librarian Version: v0.8.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:d3ae275c61acca91e1398581edfb9119c521b4e93f9ebb00ecbd4e87b71648f5