-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian update image pull request: 20260123T001116Z #15481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on essential maintenance and dependency management. It updates the core Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update from the librarian tool. It updates the generator image and applies resulting code changes across many packages. The changes primarily involve refactoring authentication scope handling, adding cryptography as an explicit dependency, and updating the python_version for mypy. My review found a significant issue with the mypy configuration: the python_version is set to 3.14, which is an invalid version and will likely break static analysis. I have added comments to all affected mypy.ini files with a suggested fix.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python 3.14 is a valid python version and has been since October of 2025.
We have added support to many of our repositories for python 3.14.
Please remember this fact when reviewing repos in github.com/googleapis
Please resolve all of the incorrect High Priority comments about python_version 3.14 that you have added to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely correct, @chalmerlowe. My apologies for the incorrect assessment regarding Python 3.14. My knowledge base was not up-to-date with the latest Python releases.
I will update my internal information to reflect that Python 3.14 is a valid version and will ensure that all related High Priority comments are resolved. Thank you for bringing this to my attention and for the clarification.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
chalmerlowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are hundreds and hundreds of files.
The vast majority of changes fall into one of about four different categories.
I looked at multiple examples of each category and noted that within a given category the changes are consistent and uniform.
I then did spot checks of numerous additional files to ensure that my presumption about uniformity was correct.
Based on that I am approving.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677