Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 23, 2026

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677

…prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
@parthea parthea requested review from a team as code owners January 23, 2026 00:12
@parthea parthea requested a review from PhongChuong January 23, 2026 00:12
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on essential maintenance and dependency management. It updates the core python-librarian-generator Docker image, streamlines authentication parameter passing in client library transports, and advances the MyPy configuration to target Python 3.14. It also explicitly lists cryptography as a direct dependency where needed. These changes collectively enhance the project's stability, security, and future compatibility.

Highlights

  • Librarian Image Update: The python-librarian-generator Docker image has been updated to a new SHA256 hash, ensuring the use of the latest version of the librarian tool.
  • Authentication Refactoring: Authentication credential handling in base transport files across numerous client libraries has been refactored. The scopes_kwargs dictionary is now removed, with its contents passed directly to google.auth.load_credentials_from_file and google.auth.default for improved clarity and direct argument passing.
  • MyPy Python Version Update: The target Python version for MyPy configurations in several packages has been updated from 3.7 to 3.14, reflecting an advancement in the project's Python version compatibility and type checking standards.
  • Dependency Management: The cryptography library has been explicitly added as a direct dependency of google-auth in various constraint files, solidifying dependency resolution and preventing potential issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated update from the librarian tool. It updates the generator image and applies resulting code changes across many packages. The changes primarily involve refactoring authentication scope handling, adding cryptography as an explicit dependency, and updating the python_version for mypy. My review found a significant issue with the mypy configuration: the python_version is set to 3.14, which is an invalid version and will likely break static analysis. I have added comments to all affected mypy.ini files with a suggested fix.

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist

python 3.14 is a valid python version and has been since October of 2025.
We have added support to many of our repositories for python 3.14.

Please remember this fact when reviewing repos in github.com/googleapis
Please resolve all of the incorrect High Priority comments about python_version 3.14 that you have added to this repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely correct, @chalmerlowe. My apologies for the incorrect assessment regarding Python 3.14. My knowledge base was not up-to-date with the latest Python releases.

I will update my internal information to reflect that Python 3.14 is a valid version and will ensure that all related High Priority comments are resolved. Thank you for bringing this to my attention and for the clarification.

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The python_version is set to 3.14, which is not a valid Python version. This will likely cause mypy to fail during static analysis. Please use a valid Python version, for example, 3.12.

python_version = 3.12

@parthea
Copy link
Contributor Author

parthea commented Jan 23, 2026

Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are hundreds and hundreds of files.
The vast majority of changes fall into one of about four different categories.
I looked at multiple examples of each category and noted that within a given category the changes are consistent and uniform.
I then did spot checks of numerous additional files to ensure that my presumption about uniformity was correct.

Based on that I am approving.

@parthea parthea merged commit 871cdee into main Jan 23, 2026
23 of 26 checks passed
@parthea parthea deleted the librarian-20260123T001116Z branch January 23, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants