chore: Nodejs error reporting migration #7009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being done to address the system test flakiness by having the most recently created error item listed first in the list of error items retrieved from the error reporting service.
The test config was only running tests that were in directories within the `test/unit` directory. Now those tests as well as test files in the `test/unit` directory itself are run.
This change is made to address the error: ``` Error: Quota exceeded for quota metric 'clouderrorreporting.googleapis.com/manage_error_events_data_requests' and limit 'ManageErrorEventsDataRequestsPerMinutePerUser' of service 'clouderrorreporting.googleapis.com' ```
Adds the `reportMode` configuration option. The `ignoreEnvironmentCheck` configuration option is now deprecated, and the `reportMode` option should be used instead. In particular, the `reportMode` can have one of three values: * 'production' (default) - Only report errors if NODE_ENV is set to "production".: * 'always' - Always report errors regardless of the value of NODE_ENV. * 'never' - Never report errors regardless of the value of NODE_ENV. Fixes #127
Automerge by dpebot
request.url can be a url.URL object. Fixes: googleapis/nodejs-error-reporting#196
chore(deps): update dependency mocha to v6 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | mocha | devDependencies | major | `^5.2.0` -> `^6.0.0` | [homepage](https://mochajs.org/), [source](https://togithub.com/mochajs/mocha) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v6.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#​600--2019-02-18) [Compare Source](https://togithub.com/mochajs/mocha/compare/v5.2.0...v6.0.0) #### 🎉 Enhancements - [#​3726](https://togithub.com/mochajs/mocha/issues/3726): Add ability to unload files from `require` cache ([**@​plroebuck**](https://togithub.com/plroebuck)) #### 🐛 Fixes - [#​3737](https://togithub.com/mochajs/mocha/issues/3737): Fix falsy values from options globals ([**@​plroebuck**](https://togithub.com/plroebuck)) - [#​3707](https://togithub.com/mochajs/mocha/issues/3707): Fix encapsulation issues for `Suite#_onlyTests` and `Suite#_onlySuites` ([**@​vkarpov15**](https://togithub.com/vkarpov15)) - [#​3711](https://togithub.com/mochajs/mocha/issues/3711): Fix diagnostic messages dealing with plurality and markup of output ([**@​plroebuck**](https://togithub.com/plroebuck)) - [#​3723](https://togithub.com/mochajs/mocha/issues/3723): Fix "reporter-option" to allow comma-separated options ([**@​boneskull**](https://togithub.com/boneskull)) - [#​3722](https://togithub.com/mochajs/mocha/issues/3722): Fix code quality and performance of `lookupFiles` and `files` ([**@​plroebuck**](https://togithub.com/plroebuck)) - [#​3650](https://togithub.com/mochajs/mocha/issues/3650), [#​3654](https://togithub.com/mochajs/mocha/issues/3654): Fix noisy error message when no files found ([**@​craigtaub**](https://togithub.com/craigtaub)) - [#​3632](https://togithub.com/mochajs/mocha/issues/3632): Tests having an empty title are no longer confused with the "root" suite ([**@​juergba**](https://togithub.com/juergba)) - [#​3666](https://togithub.com/mochajs/mocha/issues/3666): Fix missing error codes ([**@​vkarpov15**](https://togithub.com/vkarpov15)) - [#​3684](https://togithub.com/mochajs/mocha/issues/3684): Fix exiting problem in Node.js v11.7.0+ ([**@​addaleax**](https://togithub.com/addaleax)) - [#​3691](https://togithub.com/mochajs/mocha/issues/3691): Fix `--delay` (and other boolean options) not working in all cases ([**@​boneskull**](https://togithub.com/boneskull)) - [#​3692](https://togithub.com/mochajs/mocha/issues/3692): Fix invalid command-line argument usage not causing actual errors ([**@​boneskull**](https://togithub.com/boneskull)) - [#​3698](https://togithub.com/mochajs/mocha/issues/3698), [#​3699](https://togithub.com/mochajs/mocha/issues/3699): Fix debug-related Node.js options not working in all cases ([**@​boneskull**](https://togithub.com/boneskull)) - [#​3700](https://togithub.com/mochajs/mocha/issues/3700): Growl notifications now show the correct number of tests run ([**@​outsideris**](https://togithub.com/outsideris)) - [#​3686](https://togithub.com/mochajs/mocha/issues/3686): Avoid potential ReDoS when diffing large objects ([**@​cyjake**](https://togithub.com/cyjake)) - [#​3715](https://togithub.com/mochajs/mocha/issues/3715): Fix incorrect order of emitted events when used programmatically ([**@​boneskull**](https://togithub.com/boneskull)) - [#​3706](https://togithub.com/mochajs/mocha/issues/3706): Fix regression wherein `--reporter-option`/`--reporter-options` did not support comma-separated key/value pairs ([**@​boneskull**](https://togithub.com/boneskull)) #### 📖 Documentation - [#​3652](https://togithub.com/mochajs/mocha/issues/3652): Switch from Jekyll to Eleventy ([**@​Munter**](https://togithub.com/Munter)) #### 🔩 Other - [#​3677](https://togithub.com/mochajs/mocha/issues/3677): Add error objects for createUnsupportedError and createInvalidExceptionError ([**@​boneskull**](https://togithub.com/boneskull)) - [#​3733](https://togithub.com/mochajs/mocha/issues/3733): Removed unnecessary processing in post-processing hook ([**@​wanseob**](https://togithub.com/wanseob)) - [#​3730](https://togithub.com/mochajs/mocha/issues/3730): Update nyc to latest version ([**@​coreyfarrell**](https://togithub.com/coreyfarrell)) - [#​3648](https://togithub.com/mochajs/mocha/issues/3648), [#​3680](https://togithub.com/mochajs/mocha/issues/3680): Fixes to support latest versions of [unexpected](https://npm.im/unexpected) and [unexpected-sinon](https://npm.im/unexpected-sinon) ([**@​sunesimonsen**](https://togithub.com/sunesimonsen)) - [#​3638](https://togithub.com/mochajs/mocha/issues/3638): Add meta tag to site ([**@​MartijnCuppens**](https://togithub.com/MartijnCuppens)) - [#​3653](https://togithub.com/mochajs/mocha/issues/3653): Fix parts of test suite failing to run on Windows ([**@​boneskull**](https://togithub.com/boneskull)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-error-reporting). #317 automerged by dpebot
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: losalex <[email protected]>
* docs: fix node release schedule link Co-authored-by: Jeffrey Rennie <[email protected]> Source-Link: googleapis/synthtool@1a24315 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore!: upgrade to Node 14 * chore: skip system tests that are failing --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]>
…s directly from the library (#724) * chore: call non-hermetic functions since we're installing node_modules directly from the library * chore: call non-hermetic functions since we're installing node_modules directly from the library Source-Link: googleapis/synthtool@4c4063f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:8b6a07a38d1583d96b6e251ba208bd4ef0bc2a0cc37471ffc518841651d15bd6 * Update owlbot.py --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <[email protected]>
* fix: Add `system-test/fixtures` to `.eslintignore` * refactor: Use `**` Source-Link: googleapis/synthtool@b7858ba Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:abc68a9bbf4fa808b25fa16d3b11141059dc757dbc34f024744bba36c200b40f Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(docs): Update .readme-partials.yaml Removed out-dated code samples and pointed the README towards the https://cloud.google.com/error-reporting/docs/setup/nodejs documentation instead. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* test: Coerce type to fix broken tests due to depend * Try downgrading the dependency * adjust dev dependency * Upgrade dependency again * upgrade compodoc one last time * Add comment * another comment * Remove comment
* chore: use pack-n-play instead of post-install
Refs: #7009 Downgrading to 1.1.23 resolves dependency engine requirement issues (cheerio, tablesort) that were causing failures on Node 18 and Node 20 CI environments.
- Add pnpm overrides for cheerio and tablesort to support Node 18/20. - Update all license headers to 2026 Google LLC to satisfy linter. - Update package author to Google LLC.
- Move pnpm overrides to root package.json to ensure CI coverage. - Update internal copyright strings in .jsdoc.js, .OwlBot.yaml, and owlbot.py.
- Use correct pnpm.overrides nested syntax in sub-package package.json. - Add pnpm-lock.yaml to ensure transitive dependencies respect overrides in CI.
- Downgrade @compodoc/compodoc to 1.1.23. - Add bootstrap.native override (4.1.1) to satisfy pnpm 7 engine checks. - Remove pnpm-lock.yaml as it was generated by a newer pnpm version.
- Use pnpm.packageExtensions to allow bootstrap.native installation on pnpm 7. - Ensure no lockfile is present to allow CI to resolve dependencies dynamically.
- Add .npmrc with engine-strict=false to allow installation on pnpm 7 despite bootstrap.native requiring pnpm 8+. - Maintain compodoc 1.1.25 pin and Node 18 overrides.
- Revert @compodoc/compodoc to 1.1.23 to avoid strict pnpm 8+ engine requirement in bootstrap.native dependency. - Remove .npmrc as engine-strict override is no longer needed. - Keep cheerio and tablesort pnpm overrides for Node 18 compatibility.
- Add bootstrap.native 5.0.10 to devDependencies to force compatible version for pnpm 7. - Restore @compodoc/compodoc to 1.1.25 as requested. - Maintain Node 18 overrides (cheerio, tablesort).
- Removed @compodoc/compodoc and bootstrap.native from devDependencies. - Removed related documentation scripts. - Removed pnpm.overrides block specific to compodoc dependencies. This resolves the persistent pnpm engine version incompatibility in CI.
- Removed bootstrap.native which was missed in the previous commit. - This fully removes the dependency tree causing pnpm 7 incompatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/475335117 🦕