feat(gorm): implement Translate for Spanner gRPC errors#244
Open
Gage-McGuire wants to merge 2 commits into
Open
feat(gorm): implement Translate for Spanner gRPC errors#244Gage-McGuire wants to merge 2 commits into
Gage-McGuire wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #243
Only added the mapping of
AlreadyExiststogorm.ErrDuplicatedKey. There is a way to also add mappings for other error types but requires evaluating the desc of the returned errors from spanner. Which IMO could become fragile since Google states desc could be changed at anytime... (example below)