uuid: implement encoding.TextAppender and encoding.BinaryAppender#214
Open
alliasgher wants to merge 1 commit intogoogle:masterfrom
Open
uuid: implement encoding.TextAppender and encoding.BinaryAppender#214alliasgher wants to merge 1 commit intogoogle:masterfrom
alliasgher wants to merge 1 commit intogoogle:masterfrom
Conversation
Go 1.24 introduced encoding.TextAppender and encoding.BinaryAppender interfaces that allow appending encoded data to an existing byte slice without allocating. Add AppendText and AppendBinary to both UUID and NullUUID to implement these interfaces. Compared to their Marshaler counterparts, AppendText/AppendBinary append to the provided slice instead of allocating a new one each call, which is more memory-efficient in hot paths. Fixes google#193 Signed-off-by: alliasgher <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
encoding.TextAppenderandencoding.BinaryAppenderinterfaces introduced in Go 1.24 for bothUUIDandNullUUID.These interfaces (
AppendTextandAppendBinary) are the append-to-existing-slice equivalents ofTextMarshaler/BinaryMarshaler. They avoid a heap allocation in hot paths because callers can reuse a buffer.New methods
UUIDAppendText(b []byte) ([]byte, error)UUIDAppendBinary(b []byte) ([]byte, error)NullUUIDAppendText(b []byte) ([]byte, error)nullNullUUIDAppendBinary(b []byte) ([]byte, error)All new methods produce output identical to their
Marshal*counterparts.Fixes #193
Tests
TestAppendTextandTestAppendBinaryadded touuid_test.go