Skip to content

Allow client keep alive pings in worker gRPC servers #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 20, 2026
+9 −0
Merged

Allow client keep alive pings in worker gRPC servers #1928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/experimental/worker/remote_execution_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,13 @@ def test_grpc_sync_submit_survives_repeated_calls(self):
finally:
asyncio.run(handle.close()) # tears down the persistent submit loop

def test_grpc_options_tolerate_client_keepalive_pings(self):
options = dict(remote_lib._grpc_options())
self.assertEqual(
options["grpc.http2.min_recv_ping_interval_without_data_ms"], 10000
)
self.assertEqual(options["grpc.http2.max_ping_strikes"], 0)

def test_grpc_sync_start_serving_actually_serves(self):
port = portpicker.pick_unused_port()
server = remote_lib.GrpcRemoteExecutionServer(
Expand Down
2 changes: 2 additions & 0 deletions tunix/experimental/worker/remote_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ def _grpc_options() -> List[Tuple[str, int]]:
("grpc.keepalive_time_ms", 20000),
("grpc.keepalive_timeout_ms", 10000),
("grpc.keepalive_permit_without_calls", 1),
("grpc.http2.min_recv_ping_interval_without_data_ms", 10000),
("grpc.http2.max_ping_strikes", 0),
]


Expand Down
Loading