Skip to content

Fix rollout mesh axis names for gemma sharding #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 20, 2026
+1 −1
Merged

Fix rollout mesh axis names for gemma sharding #1925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tunix/experimental/examples/math_gsm8k_dist/run_rollout_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def _parse_args(argv: list[str]) -> argparse.Namespace:
def _create_rollout_mesh() -> Mesh:
shape = (1, jax.device_count())
devices = mesh_utils.create_device_mesh(shape, jax.devices())
return Mesh(devices, axis_names=("dp", "tp"))
return Mesh(devices, axis_names=("fsdp", "tp"))


def _create_vllm_worker(args, tokenizer):
Expand Down
Loading