Skip to content

fix(ts): correct session TTL minimum validation limit #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afreireo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ts): correct session TTL minimum validation limit #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sec-gemini-ts/src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,8 @@ export class InteractiveSession {
} = options;

// --- Validation ---
if (ttl <= MIN_TTL_SECONDS) {
throw new Error(`TTL must be greater than ${MIN_TTL_SECONDS} seconds.`);
if (ttl < MIN_TTL_SECONDS) {
throw new Error(`TTL must be at least ${MIN_TTL_SECONDS} seconds.`);
}
if (!model || !model.model_string) {
throw new Error('Valid ModelInfoInput object is required for registration.');
Expand Down Expand Up @@ -499,8 +499,8 @@ export class InteractiveSession {

// Apply TTL update logic
if (ttl > 0) {
if (ttl <= MIN_TTL_SECONDS) {
throw new Error(`TTL must be greater than ${MIN_TTL_SECONDS} seconds`);
if (ttl < MIN_TTL_SECONDS) {
throw new Error(`TTL must be at least ${MIN_TTL_SECONDS} seconds`);
}
updatePayload.ttl = ttl;
}
Expand Down
14 changes: 14 additions & 0 deletions sec-gemini-ts/tests/session.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,20 @@ describe('Session', () => {
jest.clearAllTimers();
openedUrl = '';
});
test('should throw error when TTL is below minimum', async () => {
const registerPromise = session.register({
ttl: 299,
model: model,
});
await expect(registerPromise).rejects.toThrow('TTL must be at least 300 seconds.');
});
test('should register session when TTL is exactly 300', async () => {
const registerPromise = session.register({
ttl: 300,
model: model,
});
await expect(registerPromise).resolves.not.toThrow();
});
test('should throw error when registering session', async () => {
// Throw error during post request to register session.
registerSession.mockImplementationOnce(() => {
Expand Down