Skip to content

Conversation

@benjaminp
Copy link
Contributor

builtin rules are removed in newer versions of Bazel

@mortenmj
Copy link
Contributor

@johnbartholomew this PR is needed to use jsonnet/go-jsonnet with Bazel 9. Do you think we could get it merged?

@johnbartholomew johnbartholomew marked this pull request as draft January 21, 2026 14:04
@johnbartholomew johnbartholomew marked this pull request as ready for review January 21, 2026 14:04
@johnbartholomew
Copy link
Collaborator

Sorry for the delay in reviewing this. Two notes:

  • It looks like rules_shell also needs to be added as a dependency in MODULE.bazel (it is used to run the test suite)
  • Please update the bazel lockfile (you can do this with bazelisk mod deps --lockfile_mode=update)

@johnbartholomew
Copy link
Collaborator

Could you also sync with master (rebase ideally, but merge if you prefer)? I have updated the CI workflow to check multiple Bazel versions for the example of using the library with bazel, and it would be good to confirm that v7, v8, and v9 all work with this PR (currently on master v7 and v8 work but v9 does not, as noted in mortenmj's comment)

@benjaminp
Copy link
Contributor Author

Thank you for the review. I have added rules_shell, merged master, and synced the lock file.

@johnbartholomew johnbartholomew merged commit a37ea3e into google:master Jan 21, 2026
9 checks passed
@johnbartholomew
Copy link
Collaborator

Rebased for linear history, and merged. Thanks!

@benjaminp benjaminp deleted the rules_cc branch January 21, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants