Fixes build on CMake 4 #1256
Merged
Fixes build on CMake 4 #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves an issue where the project fails to build with newer versions of CMake, specifically CMake 4.0, which has removed backward compatibility with versions older than 3.5. The bug was originally reported on the Debian issue tracker at #1113063: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1113063 The project's CMakeLists.txt and CMakeLists.txt.in files specify a cmake_minimum_required version of 2.8.7...4.0. This causes the build process to terminate with a fatal error on CMake 4.0 or later. The fix updates the required minimum version to 3.5...4.1 to align with the latest CMake policies and allow the project to build successfully. This change will be beneficial not only for Debian but for all other Linux distributions and operating systems running a modern CMake version. Signed-off-by: Fukui Daichi <a.dog.will.talk@akane.waseda.jp>
johnbartholomew
force-pushed
the
dfukui/fix-build-on-cmake-4
branch
from
9dd0ed3 to
077cdca
Compare
Collaborator
|
Thanks for the contribution! Bumping minimum to CMake 3.5 seems reasonable - it was released in March 2016! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves an issue where the project fails to build with newer versions of CMake, specifically CMake 4.0, which has removed backward compatibility with versions older than 3.5.
The bug was originally reported on the Debian issue tracker at #1113063:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1113063
The project's CMakeLists.txt and CMakeLists.txt.in files specify a cmake_minimum_required version of 2.8.7...4.0.
This causes the build process to terminate with a fatal error on CMake 4.0 or later.
The fix updates the required minimum version to 3.5...4.1 to align with the latest CMake policies and allow the project to build successfully.
This change will be beneficial not only for Debian but for all other Linux distributions and operating systems running a modern CMake version.