disable loop unrolling by default - #3410
Merged
Merged
Conversation
j2kun
marked this pull request as draft
September 11, 2026 17:46
j2kun
marked this pull request as ready for review
September 11, 2026 19:24
Collaborator
Author
|
@AlexanderViand fixed! I'm also not sure why the rotom_mnist test was failing, so I opted it back into loop unrolling, but I will look into that later. CC @edwjchen |
AlexanderViand
approved these changes
Sep 14, 2026
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables loop support by default in HEIR.
experimental-disable-loop-unrollis changed to be defaulttrue, and legacy tests that require unrolling loops (such as older tests of the HECO transforms) opt-in to using it.Remaining changes are updating test harness to pass through encryptions of zero as needed.