Skip to content

Fix cross-client flow response spoofing vulnerability #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vldevadath wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix cross-client flow response spoofing vulnerability #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions grr/server/grr_response_server/frontend_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ def ReceiveMessages(
flow_responses = []
for message in unprocessed_msgs:
try:
# Verify that the session_id belongs to the sender client
msg_client_id = rdf_flow_objects._ClientIDFromSessionID(message.session_id)
if msg_client_id != client_id:
logging.error("Client %s tried to spoof response for %s", client_id, msg_client_id)
continue

response = rdf_flow_objects.FlowResponseForLegacyResponse(message)
except ValueError as e:
logging.warning(
Expand Down