Migrate home screen drawer to Compose by gino-m · Pull Request #3554 · google/ground-android

gino-m · 2026-02-16T20:07:15Z

Towards #3487

Screen_recording_20260216_154137.webm

gemini-code-assist · 2026-02-16T20:07:34Z

Summary of Changes

Hello @gino-m, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Android application's architecture by refactoring the home navigation drawer into a standalone Composable, promoting better code structure and reusability. Concurrently, it establishes the necessary infrastructure for Hilt-based instrumented testing, which will enable more robust and maintainable tests for UI components. Minor documentation improvements and the removal of an obsolete agent skill are also included.

Highlights

Home Drawer Refactoring: The application's home navigation drawer has been refactored into a dedicated HomeDrawer Composable function, improving modularity and organization of the UI code.
Hilt Instrumented Test Setup: The project now includes configuration for Hilt-based instrumented tests, featuring a new CustomTestRunner to facilitate dependency injection within the test environment.
Skill Removal: The fetch_pr_comments skill, including its documentation and Python script, has been removed from the .agent/skills directory.
Documentation Update: The CONTRIBUTING.md file has been updated to clarify and reorder instructions related to setting up Google Maps API keys.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

.agent/skills/fetch_pr_comments/SKILL.md
- Removed the skill documentation file.
CONTRIBUTING.md
- Reordered and clarified the section for adding Google Maps API keys.
app/build.gradle
- Updated the testInstrumentationRunner to org.groundplatform.android.CustomTestRunner.
- Added androidTestImplementation libs.androidx.ui.test.junit4 dependency.
app/src/androidTest/java/org/groundplatform/android/CustomTestRunner.kt
- Added a new custom AndroidJUnitRunner to integrate Hilt with instrumented tests.
app/src/main/java/org/groundplatform/android/ui/home/HomeDrawer.kt
- Added a new Composable function, HomeDrawer, to encapsulate the UI and logic for the application's navigation drawer.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request refactors the home navigation drawer into a Jetpack Compose component and sets up a custom test runner for Hilt-based instrumented tests. The new HomeDrawer implementation is well-structured and follows Material 3 guidelines. I have identified a few minor issues related to accessibility (redundant content descriptions), UX (misleading ripple effects on non-interactive items), and touch target sizes that should be addressed to improve the overall quality and usability of the component.

app/src/main/java/org/groundplatform/android/ui/home/HomeDrawer.kt

codecov · 2026-02-17T01:44:36Z

Codecov Report

❌ Patch coverage is 80.25751% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.78%. Comparing base (4ab61e1) to head (c9a5878).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
...a/org/groundplatform/android/ui/home/HomeDrawer.kt	80.11%	23 Missing and 11 partials ⚠️
...oundplatform/android/ui/home/HomeScreenFragment.kt	80.76%	7 Missing and 3 partials ⚠️
...undplatform/android/ui/home/HomeScreenViewModel.kt	80.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3554      +/-   ##
============================================
+ Coverage     69.69%   69.78%   +0.08%     
- Complexity     1811     1814       +3     
============================================
  Files           349      347       -2     
  Lines          9675     9762      +87     
  Branches       1060     1047      -13     
============================================
+ Hits           6743     6812      +69     
- Misses         2298     2314      +16     
- Partials        634      636       +2

Files with missing lines	Coverage Δ
...undplatform/android/ui/home/HomeScreenViewModel.kt	`77.27% <80.00%> (+0.48%)`	⬆️
...oundplatform/android/ui/home/HomeScreenFragment.kt	`71.42% <80.76%> (-0.58%)`	⬇️
...a/org/groundplatform/android/ui/home/HomeDrawer.kt	`80.11% <80.11%> (ø)`

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

app/src/main/java/org/groundplatform/android/ui/home/HomeDrawer.kt

app/src/main/java/org/groundplatform/android/ui/home/HomeScreenFragment.kt

app/src/test/java/org/groundplatform/android/ui/home/HomeScreenFragmentTest.kt

app/src/main/java/org/groundplatform/android/ui/home/HomeDrawer.kt

…ion calls.

…tic row at the bottom of the drawer

…r.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…matting and unused resources

- Refactor HomeScreenFragment to reduce method length - Refactor HomeDrawer to extract composables - Migrate HomeScreenViewModel dialog state to StateFlow - Initialize WorkManager in HomeScreenFragmentTest - Ignore flaky sign out dialog test in Robolectric - Fix static analysis issues (detekt, ktfmt)

- Introduce `HomeDrawerAction` sealed interface to represent navigation and sign-out events. - Update `HomeDrawer` to expose a single `onAction` callback instead of multiple parameters. - Consolidate navigation logic in `HomeScreenFragment` within the `onAction` handler.

… helper.

…meScreenFragmentTest.

andreia-ferreira

Just to confirm: there are some differences in the UI (eg. the order of the menu items, horizontal dividers look different etc) is this an intended change along with the compose refactor?

Before	After

app/src/androidTest/java/org/groundplatform/android/CustomTestRunner.kt

app/build.gradle

app/src/main/java/org/groundplatform/android/ui/home/HomeDrawer.kt

app/src/main/java/org/groundplatform/android/ui/home/HomeScreenViewModel.kt

andreia-ferreira · 2026-03-10T10:45:13Z

app/src/main/res/values/styles.xml

-  </style>

-  <style name="TextAppearance.App.TitleSmall" parent="TextAppearance.Material3.TitleSmall">
+  <style name="TextAppearance.App.TitleSmall" parent="TextAppearance.Material3.TitleSmall" tools:ignore="UnusedResources">


nit: instead of adding the tools:ignore="UnusedResources, why not remove it?

andreia-ferreira · 2026-03-10T10:51:31Z

gradle/libs.versions.toml

 coreTesting = "2.2.0"
 coreTestingVersion = "1.1.1"
 coreVersion = "1.7.0"
+coilVersion = "2.7.0"


nit: coilComposeVersion is already defined in this file, that value can be used instead

andreia-ferreira · 2026-03-10T10:58:12Z

app/src/main/java/org/groundplatform/android/ui/home/HomeDrawer.kt

+import org.groundplatform.android.R
+import org.groundplatform.android.model.Survey
+import org.groundplatform.android.model.User
+import org.groundplatform.android.ui.theme.AppTheme


this import is making the build fail. It should changed due to a previous PR

Suggested change

import org.groundplatform.android.ui.theme.AppTheme

import org.groundplatform.ui.theme.AppTheme

- Restored original icons - Reordered items - Fixed typography for App title and list items - Fixed AppTheme import issue

auto-assign bot requested a review from anandwana001 February 16, 2026 20:07

gemini-code-assist bot reviewed Feb 16, 2026

View reviewed changes

gino-m changed the title ~~Refactor home drawer~~ Migrate home screen drawer to Compose Feb 16, 2026

gino-m requested review from andreia-ferreira and removed request for anandwana001 February 16, 2026 20:39

gino-m assigned andreia-ferreira Feb 16, 2026

gino-m requested a deployment to e2e-approval February 17, 2026 01:44 — with GitHub Actions Waiting

andreia-ferreira requested changes Feb 17, 2026

View reviewed changes

gino-m requested a deployment to e2e-approval February 18, 2026 02:05 — with GitHub Actions Waiting

gino-m and others added 19 commits February 22, 2026 17:55

chore: cleanup and tooling updates

fddf518

feat: add HomeDrawer component and ViewModel logic

655775a

chore: remove build output file

d886942

Clean up PR

da3f1ae

refactor(home): migrate drawer to Compose and remove XML

4ea3ae3

Restore deleted files

8748d6d

fix(home): add system bars padding to drawer

6f4f819

refactor: clean up unused imports and reformat Compose state observat…

c151380

…ion calls.

feat: move version text display from a clickable drawer item to a sta…

6cf23b4

…tic row at the bottom of the drawer

Update app/src/main/java/org/groundplatform/android/ui/home/HomeDrawe…

8cd3af2

…r.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update app/src/main/java/org/groundplatform/android/ui/home/HomeDrawe…

fa98dbf

…r.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Fix checkCode issues: Refactor HomeDrawer/HomeScreenFragment, fix for…

67c1ff6

…matting and unused resources

Fix checkCode issues and test regressions

562c1ab

Fix ktfmt formatting issues

067e9a4

Make user parameter non-null in HomeDrawer

09cd0e5

refactor: remove unnecessary comments from openSignOutWarningDialog…

a1d4e16

… helper.

Refactor HomeDrawerState into ViewModel

ae5a8f9

gino-m added 3 commits February 22, 2026 18:00

test: assert build version string with BuildConfig.VERSION_NAME in Ho…

5f7c642

…meScreenFragmentTest.

Replace Glide with Coil AsyncImage in HomeDrawer

96da66d

Fix duplicate coil-compose in libs.versions.toml

1bc876c

gino-m force-pushed the refactor/home-drawer branch from 625d941 to 1bc876c Compare February 22, 2026 23:29

gino-m temporarily deployed to e2e-approval February 22, 2026 23:46 — with GitHub Actions Inactive

gino-m requested a review from andreia-ferreira February 23, 2026 02:22

andreia-ferreira reviewed Feb 23, 2026

View reviewed changes

gino-m and others added 3 commits March 9, 2026 11:34

Address PR #3554 feedback

5640cae

Merge master into refactor/home-drawer and resolve conflicts

8bef94a

Merge branch 'master' into refactor/home-drawer

d2421c4

gino-m requested a review from andreia-ferreira March 9, 2026 17:20

andreia-ferreira reviewed Mar 10, 2026

View reviewed changes

Fix UI Home Drawer regressions

c9a5878

- Restored original icons - Reordered items - Fixed typography for App title and list items - Fixed AppTheme import issue

gino-m requested a deployment to e2e-approval March 10, 2026 15:12 — with GitHub Actions Waiting

	import org.groundplatform.android.ui.theme.AppTheme
	import org.groundplatform.ui.theme.AppTheme

Conversation

gino-m commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 16, 2026 • edited by gino-m Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andreia-ferreira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andreia-ferreira Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

andreia-ferreira Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

andreia-ferreira Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gino-m commented Feb 16, 2026 •

edited

Loading

gemini-code-assist bot commented Feb 16, 2026 •

edited by gino-m

Loading

codecov bot commented Feb 17, 2026 •

edited

Loading