Skip to content

Conversation

@gboddin
Copy link

@gboddin gboddin commented Oct 22, 2023

Calling write from parallel routines will cause the pcap file to corrupt.

Using a mutex ensure we don't corrupt the file by delaying concurrent writes.

An alternative method would be to use a buffered channel but requires an additional routine

@google-cla
Copy link

google-cla bot commented Oct 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mosajjal
Copy link

hey mate, can you move this to gopacket/gopacket and raise it there. I'll merge it over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants