-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Betania Patmos In: Version 11.002; ttfautohint (v1.8.4.16-eb64) added #10150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/huertatipografica/betania-patmos at commit huertatipografica/betania-patmos@08c83ac.
This comment was marked as outdated.
This comment was marked as outdated.
FontSpector reportfontspector version: 1.5.2 Check results[4] ofl/betaniapatmosin🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
|
| Glyph present in the font | Missing case-swapping counterpart |
|---|---|
| U+0102: LATIN CAPITAL LETTER A WITH BREVE | U+0103: LATIN SMALL LETTER A WITH BREVE |
| U+0100: LATIN CAPITAL LETTER A WITH MACRON | U+0101: LATIN SMALL LETTER A WITH MACRON |
| U+00C2: LATIN CAPITAL LETTER A WITH CIRCUMFLEX | U+00E2: LATIN SMALL LETTER A WITH CIRCUMFLEX |
| U+1E82: LATIN CAPITAL LETTER W WITH ACUTE | U+1E83: LATIN SMALL LETTER W WITH ACUTE |
| U+00D4: LATIN CAPITAL LETTER O WITH CIRCUMFLEX | U+00F4: LATIN SMALL LETTER O WITH CIRCUMFLEX |
| U+00CA: LATIN CAPITAL LETTER E WITH CIRCUMFLEX | U+00EA: LATIN SMALL LETTER E WITH CIRCUMFLEX |
| U+00DB: LATIN CAPITAL LETTER U WITH CIRCUMFLEX | U+00FB: LATIN SMALL LETTER U WITH CIRCUMFLEX |
| U+1EF2: LATIN CAPITAL LETTER Y WITH GRAVE | U+1EF3: LATIN SMALL LETTER Y WITH GRAVE |
| U+1E80: LATIN CAPITAL LETTER W WITH GRAVE | U+1E81: LATIN SMALL LETTER W WITH GRAVE |
| U+0176: LATIN CAPITAL LETTER Y WITH CIRCUMFLEX | U+0177: LATIN SMALL LETTER Y WITH CIRCUMFLEX |
| U+00DD: LATIN CAPITAL LETTER Y WITH ACUTE | U+00FD: LATIN SMALL LETTER Y WITH ACUTE |
| U+0174: LATIN CAPITAL LETTER W WITH CIRCUMFLEX | U+0175: LATIN SMALL LETTER W WITH CIRCUMFLEX |
| U+0132: LATIN CAPITAL LIGATURE IJ | U+0133: LATIN SMALL LIGATURE IJ |
| U+1E84: LATIN CAPITAL LETTER W WITH DIAERESIS | U+1E85: LATIN SMALL LETTER W WITH DIAERESIS |
| U+00CE: LATIN CAPITAL LETTER I WITH CIRCUMFLEX | U+00EE: LATIN SMALL LETTER I WITH CIRCUMFLEX |
| U+0178: LATIN CAPITAL LETTER Y WITH DIAERESIS | U+00FF: LATIN SMALL LETTER Y WITH DIAERESIS |
| U+00C5: LATIN CAPITAL LETTER A WITH RING ABOVE | U+00E5: LATIN SMALL LETTER A WITH RING ABOVE |
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
inferred from the typical amounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- uni24EA (U+24EA): found 3, expected one of: {4, 5}
- uni2460 (U+2460): found 2, expected one of: {3}
- uni2461 (U+2461): found 2, expected one of: {3}
- uni2464 (U+2464): found 2, expected one of: {4, 3}
- uni2465 (U+2465): found 3, expected one of: {4}
- uni2466 (U+2466): found 2, expected one of: {3}
- uni2467 (U+2467): found 4, expected one of: {5, 6}
- uni2468 (U+2468): found 3, expected one of: {5, 4} [code: contour-count]
⚠️ WARN Check math signs have the same width. (math_signs_width)
⚠️ WARN The most common width is 710 among a set of 16 math glyphs.
The following math glyphs have a different width, though:
width=618: notequal
width=722: uni2239
width=646: approxequal
width=653: lessequal
width=600: uni2238
width=687: logicalnot
width=621: greater, less
width=501: multiply
width=688: plus
width=636: uni2237 [code: width-outliers]
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave. (typoascender_exceeds_Agrave)
⚠️ WARN OS/2.sTypoAscender value should be greater than 1043, but got 1038 instead [code: typoAscender]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- b.init
- eth.init
- e.init
- eacute.init
- edieresis.init
- egrave.init
- uni1EBD.init
- f.init
- h.init
... and 33 others [code: unreachable-glyphs]
⚠️ WARN Check there are no overlapping path segments (overlapping_path_segments)
⚠️ WARN The following glyphs have overlapping path segments:
- v (U+0076): Line(Line { p0: (515.0, 332.0), p1: (515.0, 332.0) }) has the same coordinates as a previous segment.
- v.fina: Line(Line { p0: (515.0, 332.0), p1: (515.0, 332.0) }) has the same coordinates as a previous segment.
- v.init: Line(Line { p0: (515.0, 332.0), p1: (515.0, 332.0) }) has the same coordinates as a previous segment.
- v.isol: Line(Line { p0: (515.0, 332.0), p1: (515.0, 332.0) }) has the same coordinates as a previous segment.
- v.from.bottom: Line(Line { p0: (539.0, 332.0), p1: (539.0, 332.0) }) has the same coordinates as a previous segment.
- v.from.middle: Line(Line { p0: (507.0, 332.0), p1: (507.0, 332.0) }) has the same coordinates as a previous segment.
- v.from.top: Line(Line { p0: (410.0, 332.0), p1: (410.0, 332.0) }) has the same coordinates as a previous segment.
- v.from.bottom.fina: Line(Line { p0: (539.0, 332.0), p1: (539.0, 332.0) }) has the same coordinates as a previous segment.
- v.from.middle.fina: Line(Line { p0: (507.0, 332.0), p1: (507.0, 332.0) }) has the same coordinates as a previous segment.
... and 3 others [code: overlapping-path-segments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| BetaniaPatmosIn-Regular.ttf | |
|---|---|
| Dehinted Size | 145964 |
| Hinted Size | 195924 |
| Increase | 49960 |
| Change | 34.2 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
cvt
fpgm
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 11.002; ttfautohint (v1.8.4.16-eb64) [code: version-not-detected]
[1] ofl/betaniapatmosin/METADATA.pb
🔥 FAIL Check METADATA.pb parses correctly (googlefonts/metadata/validate)
-
🔥 FAIL METADATA.pb classifications field contains invalid value 'HANDWRITING'. Valid values are: Display, Handwriting, Monospace, Symbols [code: invalid-classification]
-
ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[2] ofl/betaniapatmosin/article/ARTICLE.en_us.html
🔥 FAIL Does DESCRIPTION file contain broken links? (googlefonts/description/broken_links)
- 🔥 FAIL The following links are broken:
- https://fonts.google.com/specimen/Betania+Patmos (status code: 404 Not Found) [code: broken-links]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/huertatipografica/betania-patmos [code: url-found]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 11 | 8 | 7 | 129 | 58 |
| 5% | 4% | 3% | 63% | 28% |
Taken from the upstream repo https://github.com/huertatipografica/betania-patmos at commit huertatipografica/betania-patmos@08c83ac.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS