Swap AST importers to populate (IR) protobuf directly instead of allocating intermediate C++ structs.#1527
Open
copybara-service[bot] wants to merge 1 commit into
Open
Swap AST importers to populate (IR) protobuf directly instead of allocating intermediate C++ structs.#1527copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_953452399
branch
2 times, most recently
from
July 24, 2026 22:46
6abca79 to
7df9a10
Compare
…cating intermediate C++ structs. This change, at a high-level: - Ports over logic to convert C++ structs -> IR protobufs to the importer, since we now skip this intermediate step. For example, we now populate the is_incomplete field to distinguish opaque from incomplete enums in the importer; we also populate CollectNamespaces directly from the IR protobuf. - Updates the per-type importers to create protobuf items instead of C++ structs. - Updates test matchers to use gmock-protobuf-matchers to simplify protobuf testing. PiperOrigin-RevId: 953452399
copybara-service
Bot
force-pushed
the
test_953452399
branch
from
July 24, 2026 22:53
7df9a10 to
2563715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap AST importers to populate (IR) protobuf directly instead of allocating intermediate C++ structs.
This change, at a high-level: