Fix speaker notes header and link contrast in Rust theme#2914
Open
juliatuttle wants to merge 1 commit intogoogle:mainfrom
Open
Fix speaker notes header and link contrast in Rust theme#2914juliatuttle wants to merge 1 commit intogoogle:mainfrom
juliatuttle wants to merge 1 commit intogoogle:mainfrom
Conversation
Despite the !important in the .content details style, links were showing up in the link color and headers were showing up in the (main) foreground color, which in the Rust theme has poor and no contrast, respectively. Fix this by explicitly forcing both to the sidebar foreground color instead.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Worth noting that this is attempting to fix #2394 |
Contributor
|
Hm, I'm trying this on my machine and I'm still seeing headers in the speaker notes having low contrast with the background: 
Unfortunately I don't know much webdev stuff, so I'm not sure what about your fix isn't working here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite the !important in the .content details style, links were showing up in the link color and headers were showing up in the (main) foreground color, which in the Rust theme has poor and no contrast, respectively.
Fix this by explicitly forcing both to the sidebar foreground color instead.