Refactor MediaType and fix imports - #483
Merged
Merged
Conversation
The google3 copy of these files carries changes this repo does not: the safevalues hardening in theme.service and analytics.service, MediaType moved out of artifact-tab into core/models/types, 1p test scaffolding in six spec files, and an @license header on audio-processor.js. Most were dropped by the revert in google#481. Adopting them here makes the two trees identical under the Copybara export transforms, so re-enabling the Piper -> GitHub postsubmit is a no-op rather than a surprise content push. Reconciling in content is also the right layer: expressing the difference as transform rules instead would permanently block the safevalues hardening from ever reaching this repo. MediaType keeps a re-export from artifact-tab.component.ts, so imports from that path are unaffected, and the enum values are unchanged. Verified: ng build clean, and ng test 628 passing -- identical to the pre-change baseline.
DeanChensj
approved these changes
Aug 18, 2026
DeanChensj
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor MediaType and fix imports