docs(memory): add memory guide and sample - #982
Merged
Merged
Conversation
AmaadMartin
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the
memorysubsystem up to adk-pythonv0.1.0: 3 module(s), unit tests, unit guide, and sample.4 files, 518 insertions, 0 deletions.
core/src/memory/core/test/memory/docs/guides/memory/index.mdsamples/memory/Modules
v0.1.0modulebase_memory_service.pycore/src/memory/base_memory_service.ts(already at parity)adk-pythonv0.1.0; documented in unit guide and exercised in samplein_memory_memory_service.pycore/src/memory/in_memory_memory_service.ts(already at parity)adk-pythonv0.1.0; documented in unit guide and exercised in samplevertex_ai_rag_memory_service.pycore/src/memory/vertex_ai_rag_memory_service.ts(already at parity)adk-pythonv0.1.0; documented in unit guide and exercised in sampleInterface discrepancies
Two divergences from
adk-pythonv0.1.0, both documented in the unit guide.adk-jsfollows the lateradk-pythonbehavior in each case.adk-pythonv0.1.0adk-jssearchMemoryresponse shapeMemoryResultobjects bysession_idMemoryEntry[]InMemoryMemoryServicekeyword matchflightdoes not matchflights)Public and protected member signatures are otherwise direct idiomatic TypeScript translations.
Deletions
0 lines across 0 files; no file on
mainis deleted.Evidence
samples/memory/, demonstratingmemoryend to end:Local verification on the branch:
npx vitest run core/test/memorynpm run buildRe-verified on this exact commit (the reviewed change squashed onto current
main):check_license.shnpm run buildWhat a reviewer should decide
core/src/memorychanges required: All3memorymodule(s) inadk-jsalready satisfyadk-pythonv0.1.0; this PR adds the unit guide and runnable sample.