fix: warn when Hutchinson estimator uses fixed PRNGKey(0) - #1738
Open
wahid18-maqs wants to merge 3 commits into
Open
fix: warn when Hutchinson estimator uses fixed PRNGKey(0)#1738wahid18-maqs wants to merge 3 commits into
wahid18-maqs wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a warning when
hutchinson_estimator_diag_hessianis initialized without arandom_seed.Changes
random_seed=None.PRNGKey(0)produces identical random vectors across runs.random_seedfor independent experiments.This change preserves the existing behavior while making the deterministic default explicit to users.