Fix load_params error reporting expected instead of actual checkpoint type - #754
Open
PratikDhanave wants to merge 1 commit into
Conversation
… type The guard 'if params.type != _CheckpointType.NESTED' raises a ValueError whose 'Got: ...' suffix interpolated the constant _CheckpointType.NESTED (the expected value), so it always printed 'Got: NESTED' regardless of the real structure. Report params.type -- the value that actually failed the check -- so the message is actionable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
gemma/gm/ckpts/_checkpoint.py,load_paramsvalidates the caller-provided params:The
Got:suffix interpolates the constant_CheckpointType.NESTED— the expected value — so the message always readsGot: ...NESTEDeven though we only reach this branch whenparams.typeis something else. Reportparams.type(the actual value that failed the check) instead, so the error tells the user what they actually passed.