Fix wrong parameter name in diffusion attention-mask error message - #745
Open
PratikDhanave wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
`_make_global_attention_mask` raises when its `num_valid_tokens` argument is None, but the ValueError text referred to `num_valid_samples`, a name that does not exist in the function signature. The sibling guard in `_make_block_local_attention_mask` already uses the correct name. Align the message with the actual parameter so the error is actionable.
PratikDhanave
force-pushed
the
fix/diffusion-attention-mask-error-message
branch
from
July 25, 2026 04:46
af72f42 to
11a8e72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
gemma/diffusion/_sampler.py,_make_global_attention_maskvalidates itsnum_valid_tokensargument:The message refers to
num_valid_samples, which is not a parameter of the function — the argument is namednum_valid_tokens. Anyone hitting this error would look for anum_valid_samplesargument that doesn't exist.The sibling guard in
_make_block_local_attention_maskalready uses the correct name ('num_valid_tokens must be provided ...').Change
Align the error message with the actual parameter name. Message-only; no behavior change.