Skip to content

Fix wrong parameter name in diffusion attention-mask error message - #745

Open
PratikDhanave wants to merge 1 commit into
google-deepmind:mainfrom
PratikDhanaveFork:fix/diffusion-attention-mask-error-message
Open

Fix wrong parameter name in diffusion attention-mask error message#745
PratikDhanave wants to merge 1 commit into
google-deepmind:mainfrom
PratikDhanaveFork:fix/diffusion-attention-mask-error-message

Conversation

@PratikDhanave

@PratikDhanave PratikDhanave commented Jul 25, 2026

Copy link
Copy Markdown

What

In gemma/diffusion/_sampler.py, _make_global_attention_mask validates its num_valid_tokens argument:

if num_valid_tokens is None:
    raise ValueError(
        'num_valid_samples must be provided if cache_length is set.'
    )

The message refers to num_valid_samples, which is not a parameter of the function — the argument is named num_valid_tokens. Anyone hitting this error would look for a num_valid_samples argument that doesn't exist.

The sibling guard in _make_block_local_attention_mask already uses the correct name ('num_valid_tokens must be provided ...').

Change

Align the error message with the actual parameter name. Message-only; no behavior change.

@google-cla

google-cla Bot commented Jul 25, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

`_make_global_attention_mask` raises when its `num_valid_tokens` argument
is None, but the ValueError text referred to `num_valid_samples`, a name
that does not exist in the function signature. The sibling guard in
`_make_block_local_attention_mask` already uses the correct name. Align
the message with the actual parameter so the error is actionable.
@PratikDhanave
PratikDhanave force-pushed the fix/diffusion-attention-mask-error-message branch from af72f42 to 11a8e72 Compare July 25, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant