Remove phantom label_smoothing attribute from NpoLoss docstring - #744
Open
PratikDhanave wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
`NpoLoss`'s docstring documented a `label_smoothing` attribute, but the dataclass has no such field and the NPO loss (`-log_sigmoid(-po_delta)`) has no label-smoothing term. The line is a copy-paste artifact from the sibling `DpoLoss`, which genuinely has and uses `label_smoothing`. A user following the NpoLoss docs would hit a TypeError passing `label_smoothing=`. Drop the stale line so the documented attributes match the actual fields.
PratikDhanave
force-pushed
the
fix/npo-loss-phantom-label-smoothing-docstring
branch
from
July 25, 2026 04:46
66b446a to
11a277f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NpoLoss(ingemma/gm/losses/_npo.py) documents alabel_smoothingattribute in its class docstring:However, the dataclass has no
label_smoothingfield, and the NPO loss it computes —-jax.nn.log_sigmoid(-po_delta)— has no label-smoothing term. The line is a copy-paste artifact from the siblingDpoLoss, which genuinely declares and useslabel_smoothingin its loss formula.A user following the
NpoLossdocs and passingNpoLoss(label_smoothing=...)would hit aTypeError, misled into thinking a knob exists that doesn't.Change
Remove the stale docstring line so the documented attributes match the actual fields. Docstring-only; no behavior change.