Repository navigation
Conversation
|
This PR (HEAD: 4567b47) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/861181. Important tips:
|
|
Message from Madeline Kalil: Patch Set 1: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-11-11T21:37:25Z","revision":"176831f41271cbb7b30d136ad97c979acaf869de"} Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from Madeline Kalil: Patch Set 1: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_3771561>) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-arm64_debian13 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from Madeline Kalil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
4567b47 to
2ce3a38
Compare
|
This PR (HEAD: 2ce3a38) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/861181. Important tips:
|
|
Message from Елена Егорова: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from Madeline Kalil: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from Madeline Kalil: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-11-16T17:18:04Z","revision":"96880bae58bd9345c659b6632a8d53954a89bcd2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from Madeline Kalil: Patch Set 2: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_3771561>) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
Message from Alan Donovan: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
2ce3a38 to
642649c
Compare
|
This PR (HEAD: 642649c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/861181. Important tips:
|
|
Message from Елена Егорова: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
The waitgroupgo fix removes a trailing wg.Done() call and lets
WaitGroup.Go call Done when the function returns. If the function
literal can return before the trailing Done, the rewrite changes
behavior: Done now also runs on the early path. Code that already
calls Done before the early return then panics with a negative
WaitGroup counter. For example:
wg.Add(1)
go func() {
if skip {
wg.Done()
return
}
wg.Done()
}()
was rewritten to
wg.Go(func() {
if skip {
wg.Done()
return
}
})
Do not report the trailing wg.Done() form when the function literal
contains a return statement outside nested function literals.
Also, to be safe, do not report either form when the function
literal uses the WaitGroup other than in the Done call of the
pattern, for example to call Done again or to pass it to other code.
Such code is often wrong, and the fix is no longer offered for it.
Fixes golang/go#82876
642649c to
5a893a7
Compare
|
Message from Alan Donovan: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
|
This PR (HEAD: 5a893a7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/861181. Important tips:
|
|
Message from Alan Donovan: Patch Set 4: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/861181. |
The waitgroupgo fix removes a trailing wg.Done() call and lets
WaitGroup.Go call Done when the function returns. If the function
literal can return before the trailing Done, the rewrite changes
behavior: Done now also runs on the early path. Code that already
calls Done before the early return then panics with a negative
WaitGroup counter. For example:
was rewritten to
Do not report the trailing wg.Done() form when the function literal
contains a return statement outside nested function literals.
Also, to be safe, do not report either form when the function
literal uses the WaitGroup other than in the Done call of the
pattern, for example to call Done again or to pass it to other code.
Such code is often wrong, and the fix is no longer offered for it.
Fixes golang/go#82876