fix: Surface API contract enforcement + Metal checkptr (#280, #281) - #282
Merged
Conversation
…licy, current project structure
…st stubs + CI cross-compile (#281) Add compile-time interface assertion to all three Surface backends ensuring public API parity (ADR-047). Missing methods return clear errors or no-op. Browser stubs: PresentPixels, WritePixels, SetPrepareFrame, SetPresentsWithTransaction Rust stubs: PresentPixels, WritePixels, SetPresentsWithTransaction CI: cross-compile job for GOOS=js/wasm (browser) and -tags=rust backends. Fixes #281.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kolkov
force-pushed
the
fix/281-surface-contract
branch
from
July 29, 2026 15:11
96fdc7f to
0746233
Compare
Third-party setup-android action (v3/v4) crashes: v3 deprecated Node16, v4 cmdline-tools 20.0 Preview license incompatible with non-interactive CI. Use runner's pre-installed SDK (cmdline-tools/latest) directly. yes | sdkmanager --licenses handles Preview license acceptance.
kolkov
force-pushed
the
fix/281-surface-contract
branch
from
July 29, 2026 15:12
0746233 to
bdd3646
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PresentPixels,WritePixels,SetPrepareFrame,SetPresentsWithTransaction— stubs added, fixes WASM build failure-racecheckptr abort in ObjC block trampolines —unsafe.Addreplaces rawuintptrarithmetic at all 4 locationsTest plan
go build ./...— nativeGOOS=js GOARCH=wasm go build .— browsergolangci-lint— 0 issues