Integration with `binsider` by godzie44 · Pull Request #45 · godzie44/BugStalker

godzie44 · 2024-10-01T15:54:58Z

No description provided.

- rename `VariableSelector` into `Selector` - rename `DqeResult` into `ScopedVariable` - use `Selector::by_name` instead of manual creating of `Name` selector - add reminder comment for oracle watchpoints

…e clashes with watchpoints)

- rename `TypeIdentity` into `TypeId` - add `TypeIdenty` type - name + namespace - use type `TypeIdenty` in `VariableIR` instead of just name

…f `VariableIR` as structure members and array items representation

orhun

This is a good start!

I realized some things are missing, so I might contribute next week. Mainly, hexdump keys and selecting dynamic libraries does not seem to be working.

Btw, how do you feel about this? Do you think the integration was worth it, is the API okay and so on? I'm happy to make improvements based on your feedback :)

orhun · 2024-10-06T17:49:11Z

+similar to readelf(1) and strace(1).
+It lets you inspect strings, examine linked libraries, and perform hexdumps, all within a user-friendly TUI.
+
+- `binsider` - run binsider inside a debugger


Consider also supporting a short version like b or bn since binsider might be a long to type.

Also, we can have more specific commands as shortcuts, for example:

static_info -> binsider --tab static-analysis

strings -> binsider --tab strings

And so on :)

Good idea! I'm add bn shortcut. About specific commands - i think it's nice too, but looks like we need to make simple api for it first :)

Sounds reasonable!

orhun · 2024-10-06T17:54:18Z

+                        break;
+                    }
+                    let command = Command::from(key);
+                    state.run_command(command, sender.clone())?;


You can also disable some commands here FYI - e.g. I'm not sure selecting dynamic dependencies work as expected.

Yep, I made it as simple as possible for two reasons:

this is a development branch of the bs and I think its ok to have some non-working functionality for now

i expect that we will be able to make all the functionality work before the next 0.x release of bs :)

godzie44 · 2024-10-06T19:39:26Z

Thank @orhun , I think current integration is a good start too, but we need to do some improvements :) I'm going to create a draft PR in binsider for your review (it should make the external API nicer to integrate)

It's sad that it's impossible to integrate BugStalker TUI into binsider now.
And what do you think about the idea of trying to integrate the bs console into binsider? Maybe you know some examples of integrating a text terminal into tui applications?

btw I've been on a little trip and now I'll have more time to work on this integration and help with the development of binsider

Closes #46

orhun · 2024-10-08T06:28:23Z

I'm going to create a draft PR in binsider for your review (it should make the external API nicer to integrate)

Just left a comment there, the rationale for the changes weren't quite clear to me.

It's sad that it's impossible to integrate BugStalker TUI into binsider now.

I don't think it is impossible, it is just a bit of work.

And what do you think about the idea of trying to integrate the bs console into binsider? Maybe you know some examples of integrating a text terminal into tui applications?

Yup, I think in the worst case we can spawn a terminal inside the TUI (using tui-term). However, I need to look into the API of BugStalker first to make sure, do you have any API usage examples & other apps depending on BugStalker for now?

I will look into this and try to integrate something (on stream, probably).

godzie44 · 2024-10-08T09:01:44Z

No, there is no other apps that using bs. As example i can only show this function https://github.com/godzie44/BugStalker/blob/master/src/ui/console/mod.rs#L376.

Unfortunately, this also all looks complicated :(

godzie44 added 8 commits September 15, 2024 18:50

refactoring(debugger): refactor select module

8070cb6

- rename `VariableSelector` into `Selector` - rename `DqeResult` into `ScopedVariable` - use `Selector::by_name` instead of manual creating of `Name` selector - add reminder comment for oracle watchpoints

refactoring(oracle): rename watch_point -> spy_point (watch_point nam…

8eec93b

…e clashes with watchpoints)

refactoring(debugger): new TypeIdentity structure

b229949

- rename `TypeIdentity` into `TypeId` - add `TypeIdenty` type - name + namespace - use type `TypeIdenty` in `VariableIR` instead of just name

feature(debugger): add support for SystemTime and Instant std types

46e0984

feature(debugger): add support for constant initialized TLS variables

729f77d

refactor(debugger): refactor variables specialized representation

a8bab20

refactor(debugger): add Member and ArrayItem structures instead o…

786fc44

…f `VariableIR` as structure members and array items representation

refactor(debugger): variable module refactoring

5183ff0

godzie44 force-pushed the godzie44/binsider branch from 7f8cc50 to 70cff26 Compare October 2, 2024 11:32

godzie44 mentioned this pull request Oct 2, 2024

Support GDB orhun/binsider#29

Open

orhun reviewed Oct 6, 2024

View reviewed changes

godzie44 added 2 commits October 6, 2024 22:49

feature(debugger): binsider integration

05ffb24

Closes #46

chore: fix deprecated warnings for chrono

8bb8de5

godzie44 force-pushed the godzie44/binsider branch from 70cff26 to 8bb8de5 Compare October 6, 2024 19:49

orhun mentioned this pull request Oct 9, 2024

Godzie44/run as widget orhun/binsider#73

Open

godzie44 force-pushed the godzie44/binsider branch from bdcd916 to 30abee3 Compare October 9, 2024 16:02

tmp: improve binsider integration

dcb557f

godzie44 force-pushed the godzie44/binsider branch from 30abee3 to dcb557f Compare October 9, 2024 17:27

godzie44 force-pushed the develop branch from 5183ff0 to 4e6a2f8 Compare October 20, 2024 17:35

godzie44 force-pushed the develop branch from 07628a2 to ab532e0 Compare November 30, 2024 17:21

godzie44 force-pushed the develop branch from ab532e0 to f382288 Compare January 12, 2025 10:58

godzie44 force-pushed the develop branch 4 times, most recently from 9d142f1 to cb0993d Compare February 24, 2025 15:16

godzie44 force-pushed the develop branch from 9c7ccdb to 687404d Compare April 7, 2025 09:55

Navigation Menu

Integration with `binsider` - #45

Integration with `binsider`#45
godzie44 wants to merge 11 commits into
developfrom
godzie44/binsider

godzie44 commented Oct 1, 2024

Uh oh!

orhun left a comment

Uh oh!

Uh oh!

orhun Oct 6, 2024

Uh oh!

godzie44 Oct 6, 2024

Uh oh!

orhun Oct 8, 2024

Uh oh!

orhun Oct 6, 2024

Uh oh!

godzie44 Oct 6, 2024

Uh oh!

godzie44 commented Oct 6, 2024

Uh oh!

orhun commented Oct 8, 2024

Uh oh!

godzie44 commented Oct 8, 2024

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

godzie44 commented Oct 1, 2024

Uh oh!

orhun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

orhun Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

godzie44 Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

orhun Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

orhun Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

godzie44 Oct 6, 2024

Choose a reason for hiding this comment

Uh oh!

godzie44 commented Oct 6, 2024

Uh oh!

orhun commented Oct 8, 2024

Uh oh!

godzie44 commented Oct 8, 2024

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants