feat(shopping): suggest the next step after checkout get and other shopping commands by jpage-godaddy · Pull Request #366 · godaddy/cli

jpage-godaddy · 2026-11-05T20:19:47Z

Summary

gddy shopping checkout get returned no next actions, so the flow dead-ended at the review step: checkout create and checkout update point at get, and nothing pointed on to checkout complete. It now suggests a next step based on the checkout session's state:

State	Suggested next step
Ready, payment method selected	`shopping checkout complete <checkout-id>`, with the agreement-review reminder and the `AI assistants:` note
Incomplete or ready, saved methods available but none selected	`shopping checkout update <checkout-id> --payment-instrument <instrument-id>`
Incomplete or ready, no saved payment method	`payment-method add`
Completed with an order	`shopping order get <order-id> --wait`
Order still being placed (in progress, or completed without an order ID yet)	`shopping checkout get <checkout-id>` again, noting the order can take a few seconds and must not be placed twice
Any other or unrecognised status	none

Completion is only ever suggested for a ready checkout with a selected payment method.

No suggestion includes --agree or any other consent flag; completion stays gated on the explicit review.

Other shopping commands that ended without a next step now point onward:

catalog lookup suggests checkout create for the first available purchase option, matching catalog get and catalog search (they now share one helper).
catalog category suggests catalog search --category <category>.
checkout complete points at checkout get when the order ID is not returned straight away, and checkout get keeps suggesting a re-check until the order appears.

The shopping guide no longer says to avoid checkout get after an order is placed, since it now links to the order.

Completed-checkout behaviour relies on the completed status and order.id field described in the Shopping API spec; they have not been confirmed against a live completed session. An unrecognised status gets no suggestion.

Test plan

Unit tests for each checkout get state, including that no action contains --agree
Unit tests for the catalog lookup, catalog category and checkout complete actions
cargo check, cargo clippy --workspace -- -D warnings, cargo test --workspace, cargo fmt --check, check-module-size.sh

Resolves DEVEX-1277

🤖 Generated with Claude Code

…opping commands `shopping checkout get` now suggests what to do next based on the checkout session's state: place the order when a payment method is selected, select a saved payment method when none is, add a payment method when none is saved, and review the order once the checkout is completed. A checkout that is not ready gets no completion suggestion, and no suggestion ever includes --agree. Other shopping commands that ended without a next step now point onward: `catalog lookup` suggests starting a checkout, `catalog category` suggests searching a category, and `checkout complete` points at the checkout session when the order ID is not returned straight away. The shopping guide no longer tells customers to avoid `checkout get` after placing an order, since it now links to the order. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Copilot

🟡 Changes recommended

Checkout guidance suggests adding a payment method for ineligible statuses, and the completed-order follow-up omits --wait, risking a transient 404 after a successful purchase.

2 open issues

What changed in this PR

This PR connects previously disconnected steps in the shopping CLI by adding follow-up actions for catalog browsing, checkout review, and order retrieval.

Changes:

Adds checkout-state-based guidance while preserving explicit purchase consent.
Adds catalog follow-ups and shares checkout-creation action construction.
Adds an order-retrieval fallback, unit tests, and updated shopping guidance.

File	Description
`rust/src/shopping/guides/shopping.md`	Documents retrieving an order ID through its checkout session.
`rust/src/shopping/checkout/get.rs`	Adds state-based next actions and tests.
`rust/src/shopping/checkout/create.rs`	Extracts the shared agreement-review reminder.
`rust/src/shopping/checkout/complete.rs`	Suggests retrieving the checkout when no order ID is returned.
`rust/src/shopping/catalog/search.rs`	Reuses the shared checkout-creation action.
`rust/src/shopping/catalog/mod.rs`	Defines the shared checkout-creation action helper.
`rust/src/shopping/catalog/lookup.rs`	Suggests checkout for the first available purchase option.
`rust/src/shopping/catalog/get.rs`	Reuses the shared checkout-creation action.
`rust/src/shopping/catalog/categories.rs`	Adds a category-search next action and tests.

_{Review effort: Balanced}

`checkout get` now suggests adding or selecting a payment method only for a checkout that is ready to place, so a canceled, in-progress or unrecognised checkout with no saved methods no longer points at `payment-method add`. The order suggested for a completed checkout waits for the order to become visible, matching the suggestion shown right after placing an order, so following it straight away no longer fails with a not-found error. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Copilot

🟢 Approval recommended

No active review issues are reported for the shopping next-step suggestion changes.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

sswaminathan-godaddy · 2026-11-06T03:11:18Z

Could we retain the payment-method add suggestion for an incomplete checkout with no saved payment methods?

Reproduced on this branch in prod: shopping checkout create --item titanemail-light:1yr --currency USD returned Status: incomplete, no selected payment method, and a next step to run gddy payment-method add. Running shopping checkout get for the same session returned the same state but no next steps.

This is a gap in the new next-step guidance rather than a regression: main does not attach next actions to checkout get.

In checkout/get.rs, no_saved_payment_method_action currently runs only for ready_for_complete. Please also offer the add-payment suggestion for incomplete sessions with no saved methods, while keeping the completion suggestion restricted to ready_for_complete, and cover that state with a test.

sswaminathan-godaddy

approved, added a suggestion

rts1-godaddy · 2026-11-06T14:17:24Z

+/// Points at the order once the API returns its ID; an accepted completion
+/// without one is followed up through the checkout session, which links to the
+/// order as soon as it exists.
+fn order_follow_up_action(order_id: Option<String>, checkout_id: &str) -> cli_engine::NextAction {


If complete returns no order.id, we point at checkout get. For status=completed without order.id, get then suggests nothing, so the agent/user can loop with no progress. Can we have get suggest retrying get (or waiting) when completed-but-no-order, or soften this fallback description to say the order ID may take a few seconds and to re-run get until it appears.

Good catch, thanks. Fixed in 38688b6. checkout get now suggests checking again (shopping checkout get <checkout-id>) for a completed checkout without an order ID and for complete_in_progress, with wording that the order can take a few seconds and must not be placed twice. The fallback in checkout complete uses the same action. For AI assistants the description asks them to check a few times at most and then report the order as still pending, so they don't loop indefinitely.

…ry pending orders `checkout get` suggests adding or selecting a saved payment method for an incomplete checkout as well as a ready one, matching `checkout create`, which reports a new checkout with no payment method as incomplete. Completion is still only suggested once the checkout is ready and a payment method is selected. When an order is still being placed, `checkout get` and `checkout complete` now suggest checking the checkout session again, noting that the order can take a few seconds to appear and must not be placed twice, instead of ending without a next step. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

…e guide Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jpage-godaddy · 2026-11-06T20:40:29Z

Thanks, @sswaminathan-godaddy. Fixed in 38688b6. checkout get now suggests payment-method add for an incomplete checkout with no saved payment methods, and completion is still only suggested for ready_for_complete with a selected payment method. I also made an incomplete checkout with saved but unselected methods suggest selecting one, so that case does not dead-end either. Tests cover both states.

Copilot

🔵 Needs a closer look

Live Shopping API behavior for completed sessions, order IDs, and delayed-completion polling remains unverified, requiring human validation before relying on purchase-recovery guidance.

No open issues 🎉

_{Review effort: Balanced}

jpage-godaddy requested review from axburgess-godaddy, jpearlman-godaddy, mguerrero3-godaddy, qcai-godaddy, rts1-godaddy and sswaminathan-godaddy as code owners November 5, 2026 20:19

Copilot AI balanced review requested due to automatic review settings November 5, 2026 20:19

Copilot started reviewing on behalf of jpage-godaddy November 5, 2026 20:20

View session

Copilot AI reviewed Nov 5, 2026

View reviewed changes

Comment thread rust/src/shopping/checkout/get.rs Resolved

Comment thread rust/src/shopping/checkout/get.rs Resolved

jpage-godaddy requested a balanced review from Copilot November 5, 2026 20:25

Copilot started reviewing on behalf of jpage-godaddy November 5, 2026 20:25

View session

Copilot AI reviewed Nov 5, 2026

View reviewed changes

sswaminathan-godaddy approved these changes Nov 6, 2026

View reviewed changes

rts1-godaddy reviewed Nov 6, 2026

View reviewed changes

rts1-godaddy approved these changes Nov 6, 2026

View reviewed changes

jpage-godaddy and others added 2 commits November 6, 2026 12:39

docs(shopping): mention the next step suggested by checkout get in th…

055a679

…e guide Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jpage-godaddy requested a balanced review from Copilot November 6, 2026 20:40

Copilot started reviewing on behalf of jpage-godaddy November 6, 2026 20:40

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Remove weird mention of the command giving next steps

e0eee4e

jpage-godaddy merged commit 72f25e8 into main Nov 6, 2026
4 checks passed

jpage-godaddy deleted the checkout-next-steps branch November 6, 2026 23:05

github-actions Bot mentioned this pull request Nov 6, 2026

chore(main): release 0.2.37 #367

Open

Navigation Menu

Repository navigation

feat(shopping): suggest the next step after checkout get and other shopping commands - #366

feat(shopping): suggest the next step after checkout get and other shopping commands#366
jpage-godaddy merged 5 commits into
mainfrom
checkout-next-steps

jpage-godaddy commented Nov 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

sswaminathan-godaddy commented Nov 6, 2026

Uh oh!

sswaminathan-godaddy left a comment

Uh oh!

rts1-godaddy Nov 6, 2026

Uh oh!

jpage-godaddy Nov 6, 2026

Uh oh!

jpage-godaddy commented Nov 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jpage-godaddy commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

sswaminathan-godaddy commented Nov 6, 2026

Uh oh!

sswaminathan-godaddy left a comment

Choose a reason for hiding this comment

Uh oh!

rts1-godaddy Nov 6, 2026

Choose a reason for hiding this comment

Uh oh!

jpage-godaddy Nov 6, 2026

Choose a reason for hiding this comment

Uh oh!

jpage-godaddy commented Nov 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jpage-godaddy commented Nov 5, 2026 •

edited

Loading